Repository navigation
Validate feature-name counts and add public API contract tests - #609
Merged
Merged
Conversation
imatiach-msft
force-pushed
the
fix/api-contract-feature-validation-108-91
branch
from
November 6, 2026 16:54
b5e19df to
69202f1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 88.07% 88.34% +0.26%
==========================================
Files 59 59
Lines 4077 4127 +50
==========================================
+ Hits 3591 3646 +55
+ Misses 486 481 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #108.
Closes #91.
Validation
python tests\run_tests.py --compatibility-only -q:The six older-SHAP skips cover bare statistical dictionaries that upstream SHAP does not support. Tests probe upstream support; interpret-community failures are not suppressed.
git diff --check, passed.69202f1: full Python 3.10-3.14 tests, all four NumPy compatibility jobs, dashboard, lint, CodeQL/code scan, DCO, and both Codecov checks. The initial partial-coverage failures cleared after the unit-test coverage upload.Recursive review
Eight independent full-diff rounds used GPT-6.1 Sol, Claude Sonnet 5.5, and Grok 4.7, each explicitly requesting maximum reasoning. Runtime-reported models matched; effective reasoning effort was not separately reported. All three final reviewers reported no actionable findings.
One documented concern was rejected: preserving incidental acceptance of
None/list initialization backgrounds with explicit names is outside TabularExplainer's documented ndarray/DataFrame/csr input contract.Final review status: clean with documented rejected findings.