[UgaTheDev]

docs/ci.md points at tests/smoketest.sh under "Smoke tests" without
saying whether CI runs it. It doesn't: smoke.yaml invokes
tox -e py3-smoke, which (tox.ini) runs pytest tests/smoke, never
tests/smoketest.sh. The script still covers axes the pytest matrix doesn't
(flash-attention on/off, Granite on/off, FSDP+LoRA), so it's not redundant —
just orphaned and easy to mistake for something CI already checks.

This adds one sentence making that explicit and pointing at #705, where the
consolidation question (fold smoketest.sh's cases into
test_training_feature_matrix, or delete it) is still open and needs a
maintainer decision — actually reconciling the two test surfaces is a bigger
change than a docs PR should carry.

Originally flagged in #705 (comment from 2026-07-29): "There's a second smoke test nobody runs... No workflow calls it anymore, since smoke.yaml invokes tox -e py3-smoke which only points at tests/smoke/. It's dead as far as CI goes but still checked in and still exercising real coverage."

One-line diff, docs/ci.md only.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 251c5692-3b9d-4178-81bb-9828fa9776a4

Commits

Reviewing files that changed from the base of the PR and between da76404 and cbfc060.

Files selected for processing: 1

• docs/ci.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[Maxusmusti]

The headline is correct — no workflow invokes tests/smoketest.sh (smoke.yaml and smoke-py312.yaml both go through the run-smoke action → tox -e py3-smoke → pytest tests/smoke). But the added sentence overstates what the script still covers:

• The script is broken, not just orphaned. test_standard_loop passes --is_granite, which was removed from main_ds.py's argparse in #257, so parse_args() exits with "unrecognized arguments". The script runs with set -eux -o pipefail, so it aborts there and test_standard_loop_fsdp_lora (run after it in main()) is never reached. The script hasn't been touched since 2024-11.
• "Granite on/off" isn't a real axis anymore — every test uses instructlab/granite-7b-lab; the on/off was just that removed flag.
• Flash-attention off and FSDP+LoRA genuinely aren't covered by the pytest smoke matrix, so that part is fair — but FSDP+LoRA isn't actually reachable in the script today.
• Smaller points: it names only smoke.yaml (there's also smoke-py312.yaml), and pointing docs at an issue for coverage details will go stale once #705 is closed.

Suggested wording:

There is also a Shell-based smoke test script at tests/smoketest.sh. It is not run by any CI workflow and is currently stale (e.g. it passes the removed --is_granite flag); see #705.

[UgaTheDev]

Thanks for the detailed check. I replaced the sentence with your wording: the script is not run by any CI workflow and is currently stale (e.g. it passes the removed --is_granite flag), see #705. Pushed.