Repository navigation
Release by open-opam alone - #2
Merged
Merged
Conversation
make release refused a commit whose CHANGES.md did not open with the version and today's date, so the version was named in a pull request of its own and renamed again when a release ran past midnight. It now checks the version alone, which the pull request that completes the release names, as Hypha's LIBRARY.md says.
open-opam release already holds a commit to its CI and open-opam's gates before it tags it; the check of CHANGES.md's heading beside it added nothing a release needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
make release checked that CHANGES.md opened with the version and today's date before it ran open-opam, so a release needed a pull request of its own to rename the heading, and another when it ran past midnight. open-opam release already holds the commit to its CI and open-opam's gates before it tags it.
Changes
make release VERSION=xrunsopen-opam release xalone; it no longer reads CHANGES.md.Verified