Repository navigation
fix(web): keep long invited addresses inside the Google sign-in button - #373
Merged
Merged
Conversation
On an invitation, the button said 'Continue with Google as <address>' on one line: any address wrapped it out of its 40 px, and the mark shrank. The address now has a line of its own under the label, cut short with its name before its domain, and the subtitle sets it apart and breaks it before its @.
kalaspuff
approved these changes
Nov 4, 2026
kalaspuff
deleted the
fctl/633-on-the-signup-page-when-invited-for-earl
branch
November 4, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On an invitation's signup page, the Google button said "Continue with Google as
" on one 40 px line, so almost any address wrapped out of the button and squeezed the Google mark. The button now puts "Continue with Google" on top and the address on its own line beneath it, with an arrow at the end. When the address doesn't fit, the part before the@is cut short first and the domain keeps up to two thirds of the line, so you can still tell a Gmail account from a work account. The full address is in the button's tooltip and accessible name. The sign-in page's plain "Continue with Google" button looks the same as before.The page's subtitle (and the "Connect … to this account" text for someone already signed in) now shows the address in the primary text color and breaks it before its
@, not at a hyphen in the middle of the name. I checked the page in Playwright at 375 and 1280 px in both themes with a short and a 65-character address, against a mocked invitation.npm run checkand the web tests pass.Before and after on a phone, dark theme, with a long address:
Before and after on a desktop, light theme, with a short address (it filled the button edge to edge before):
Worth confirming
login_hint, so the button names the invited address without preselecting it. Passing it would need a separate change in the control plane.fctl session
Note
Low risk. A presentation-only change to the sign-in and invitation pages in the web app; no auth logic, API or stored data changes.
What it does. On the invitation page, a long invited email address no longer stretches the Google sign-in button or overflows the text. The button now shows the address on its own line under
Continue with Google, cutting the name part short before the domain, and the address in running text breaks before its@. The Google logo moves into aGoogleMarkcomponent, and the plain login button looks as before.fctl review's first look at
7d258e9· 1 file, +78 −26 · Review agent settings