Skip to content

fix(web): keep long invited addresses inside the Google sign-in button - #373

Merged
kalaspuff merged 1 commit into
mainfrom
fctl/633-on-the-signup-page-when-invited-for-earl
Nov 4, 2026
Merged

kalaspuff merged 1 commit into
mainfrom
fctl/633-on-the-signup-page-when-invited-for-earl

Conversation

@fctl-sh

@fctl-sh fctl-sh Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

On an invitation's signup page, the Google button said "Continue with Google as

" on one 40 px line, so almost any address wrapped out of the button and squeezed the Google mark. The button now puts "Continue with Google" on top and the address on its own line beneath it, with an arrow at the end. When the address doesn't fit, the part before the @ is cut short first and the domain keeps up to two thirds of the line, so you can still tell a Gmail account from a work account. The full address is in the button's tooltip and accessible name. The sign-in page's plain "Continue with Google" button looks the same as before.

The page's subtitle (and the "Connect … to this account" text for someone already signed in) now shows the address in the primary text color and breaks it before its @, not at a hyphen in the middle of the name. I checked the page in Playwright at 375 and 1280 px in both themes with a short and a 65-character address, against a mocked invitation. npm run check and the web tests pass.

Before and after on a phone, dark theme, with a long address:

before-65-dark-375.png after-65-dark-375.png

Before and after on a desktop, light theme, with a short address (it filled the button edge to edge before):

before-19-light-1280.png after-19-light-1280.png

Worth confirming

  • Decision: In the button, a long address is cut short rather than wrapped, so the button always stays the same height (56 px). The full address is still in the subtitle and the Email field just below.
  • Assumption: Google's account chooser still opens on whichever account the browser picks. The control plane's Google start doesn't pass login_hint, so the button names the invited address without preselecting it. Passing it would need a separate change in the control plane.

fctl session


Note

Low risk. A presentation-only change to the sign-in and invitation pages in the web app; no auth logic, API or stored data changes.

What it does. On the invitation page, a long invited email address no longer stretches the Google sign-in button or overflows the text. The button now shows the address on its own line under Continue with Google, cutting the name part short before the domain, and the address in running text breaks before its @. The Google logo moves into a GoogleMark component, and the plain login button looks as before.

fctl review's first look at 7d258e9 · 1 file, +78 −26 · Review agent settings

On an invitation, the button said 'Continue with Google as <address>' on
one line: any address wrapped it out of its 40 px, and the mark shrank.
The address now has a line of its own under the label, cut short with
its name before its domain, and the subtitle sets it apart and breaks
it before its @.
@fctl-sh
fctl-sh Bot requested a review from kalaspuff as a code owner November 4, 2026 14:06
@kalaspuff
kalaspuff merged commit ce7ac3f into main Nov 4, 2026
11 checks passed
@kalaspuff
kalaspuff deleted the fctl/633-on-the-signup-page-when-invited-for-earl branch November 4, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant