Repository navigation
feat: odo instances protect/unprotect - #21
Draft
hostodo-hermes-operations[bot] wants to merge 1 commit into
Draft
hostodo-hermes-operations[bot] wants to merge 1 commit into
hostodo-hermes-operations[bot] wants to merge 1 commit into
Conversation
Adds the protection field to instance list/show, protect and unprotect commands with an explicit UNPROTECT confirmation, and blocks reinstall/rename client-side with the server error surfaced.
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
odo instances protect/unprotectplus protection state in list and show.UNPROTECT <id>confirmation on unprotect; the command never retries the previously blocked action.cmd/instances/protection_test.go,cmd/protection_test.go,pkg/api/protection_test.go,pkg/auth/oauth_test.go,pkg/ui/protection_test.go.Recovered from the Amp orb (thread
T-01a16fe2) after its executor died;make testnot re-run here. Draft, review required. Do not merge without Hassan's explicit OK.