Repository navigation
Report popup step views, starts and completions - #105
Merged
Merged
Conversation
The popup now reports its steps through Hellotext.track, with the popup's and the step's public ids, for the popup report's per-step funnels: - popup.step_viewed when the dialog shows a step: when it opens automatically or from a short link, after a bubble click, or when the visitor reaches or returns to the step. The bubble alone doesn't count. - popup.step_started on the first input in one of the step's fields. Focus alone doesn't count. - popup.step_completed when the step passes validation and the visitor moves on. The last step never reports it: sending the popup completes it, and Hellotext counts the submission. Each report is sent once per session, popup, step and local day. The daily mark is written only when the server accepted the report, so a failed one is sent again the next time. Tracking errors never reach the popup. Rebuilt lib and dist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it sends
The popup controller reports its steps through
Hellotext.track, withpopup_id,step_id(the step'sdata-step-id) andtracked_at:popup.step_viewedshowInitialState()(automatic or short-link open),open()(bubble click) andshowStep()(moving to a step, or returning to one after a cancellation or server errors). The bubble alone, and the completion screen, don't count.popup.step_startedinputevent in one of the step's fields. Focus alone doesn't count.popup.step_completednext(), when the step passes validation and the visitor moves on. The last step never sends it: sending the popup completes it, and the server counts the submission.Each report is sent once per session, popup, step and local day, with a localStorage mark written only when the server accepted it, the same pattern as
form.started(#104). A failed report is sent again the next time, and tracking errors never reach the popup.Release
Release after hellotext/hellotext#6947 is deployed. Before that, the server answers 404 to these actions, so no mark is written and the reports are just sent again later.
Tests
New "step tracking" cases in
__tests__/controllers/popup_controller_test.js. The full suite passes locally (1175 tests).docs/popups.mdhas a new "Step reporting" section. lib and dist are rebuilt from a freshyarn install --frozen-lockfile.🤖 Generated with Claude Code