Repository navigation
fix: run on PHP 7.4 and pass the Woo Marketplace checks (2.0.2) - #55
Merged
Merged
Conversation
The Woo Marketplace tests the upload on PHP 7.4, where 2.0.1 failed to load: `match`, union types and `mixed` are PHP 8 only. They are now array lookups and docblock types. The header declares the supported WordPress, WooCommerce and PHP versions, and HPOS compatibility (orders only go through the WooCommerce order API). Failed requests log to the WooCommerce logger instead of error_log, and the checkout link's products and the Webchat card's source are sanitized before they are read. Bumps the version to 2.0.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Woo Marketplace rejects a zip whose root folder is not the plugin slug, hellotext. The release workflow now packages release/hellotext/ as hellotext.zip, and the CI package check verifies that layout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Woo Marketplace runs its Quality Insights Toolkit (QIT) on every upload, and 2.0.1 failed it. The tests run on PHP 7.4, where the plugin did not load:
match, union types andmixedare PHP 8 only, soOrderStatus.phpwas a parse error and activation failed.PHP 7.4
matchblocks are array lookups now. The union andmixedtypes are removed from the adapters,Session::decryptand the hook callbacks; their docblocks keep the types.Header validation
Requires at least: 6.5,Tested up to: 7.1,Requires PHP: 7.4,WC requires at least: 8.0andWC tested up to: 11.2, and so doesreadme.txtfor the WordPress versions.$order->get_meta()/update_meta_data().Security scan
productsand the Webchat card'shellotext_sourcego throughsanitize_text_field.hellotext) instead oferror_log, still only withWP_DEBUGon.Release zip
hellotext. The release workflow now buildshellotext.zipfromrelease/hellotext/, and the CI package check verifies that layout.Bumps the version to 2.0.2.
Testing
php:7.4-cli), and the classes autoload there.testVersion 7.4-) andWordPress.Security.ValidatedSanitizedInputfind nothing. Onmainthey report the same 19 compatibility errors and 2 unsanitized inputs as QIT.After merging, tag
v2.0.2onmainto publish the release.🤖 Generated with Claude Code