Repository navigation
fix(skills): keep private-package skills out of the public repo - #2148
Open
aarontrowbridge wants to merge 1 commit into
Open
aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
Remove the two private-package usage skills from the shipped library (their home is now the team vault as internal skills) and reword the public skills that named private packages to neutral premium-tier language, without changing public-package guidance. Add a `private-package` rule to the skill-library lint: a shippable skill naming a package on the denylist (one file, scripts/lint-skills-private-packages.txt) fails. On by default for the repo library; internal cards are exempt; zero exceptions. Stage the relocated skills for headless sessions via the internal skills allowlist, and amend ADR-0011 with the new placement. Refs #2147
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2147.
What
packages/extension/skills/. They now live in the team vault as internal skills.formulation-display,intonatoqick,migrate-research-project,amico-catalog,amico-strategy,analyze,amico-schema-check,develop) to neutral premium-tier language. Public-package guidance is unchanged. Twoformulation-displayrows now name constructors that the public Piccolo exports.private-packageinscripts/lint-skills.mjs: a shippable skill (surfacepublic,entitled, or untagged) that names a denylisted package fails, whether the name is in the frontmatter or the body. The denylist lives in one file,scripts/lint-skills-private-packages.txt. The rule is on by default for the repo library and opt-in via--denylistfor other roots, andinternalcards are exempt. The exception list (lint-skills-known.txt) is empty, and a test pins it that way.ops/server/stage-internal-skills.sh, and the golden test is updated.native_skillsentitled-gate test now uses a fixture library root, because the shipped library no longer has an entitled skill.TDD
The five new
skills_integritytests were written first and failed (5 RED) before the rule existed. After the rule landed, the real library showed 52 hits, and the sanitization brought it to 0.Gate (baseline → after)
lint-skillswithout--knownlint:skills(with--known)tsc --noEmitThe pre-existing drift-lint failure is out of scope and left untouched.