Skip to content

Migrate to pnpm + Next.js 16 - #242

Merged
yaoguz merged 7 commits into
masterfrom
pnpm-and-nextjs
Nov 21, 2026
Merged

yaoguz merged 7 commits into
masterfrom
pnpm-and-nextjs

Conversation

@HectorSuArGit

Copy link
Copy Markdown
Contributor

Why: Next 14 had unpatched vulnerabilities (1 critical remote code execution in Image Optimization, plus DoS and SSRF), and the Dependabot bump broke CI.

Changes

  • npm → pnpm (pnpm@12.21.0): dependency install scripts only run if approved, plus a 7-day minimumReleaseAge to guard against compromised packages.
  • Next 14 → 16.4.5 and React 18 → 19. @fortawesome/react-fontawesome goes to 3.5, since 0.2 broke the build.
  • ESLint 9 with flat config (eslint.config.mjs), since Next 16 removed next lint. Our custom rules are kept.
  • Static export (output: "export"): no Next.js server in production.
  • Netlify config in the repo (netlify.toml): builds with pnpm build and publishes out/.
  • CI: uses pnpm, takes the Node version from .nvmrc, and adds a pnpm build step.
  • styled-components: $-prefixed props so they don't end up in the HTML.

Héctor and others added 6 commits November 15, 2026 22:27
- next and @next/third-parties 16.4.5, react/react-dom 19
- @fortawesome/react-fontawesome 0.2 -> 3.5 (0.2 crashes prerender on
  React 19: className.split on undefined)
- bump embla-carousel, html-react-parser, styled-components and
  typescript within range for React 19 support
- tsconfig: jsx react-jsx and .next/dev types, as written by Next 16

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Next 16 removed `next lint` and eslint-config-next 16 requires ESLint 9.

- eslint.config.mjs: next core-web-vitals + typescript, react
  recommended rules and the project's previous custom rules
- lint scripts now call the ESLint CLI
- drop unused eslint-config-airbnb and deps now provided by
  eslint-config-next (@typescript-eslint/eslint-plugin, eslint-plugin-import)
- CookiesBanner: read consent with useSyncExternalStore instead of
  setState in an effect (react-hooks/set-state-in-effect)
- remove eslint-disable comments that are no longer needed

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The site has no server-side features, so `output: "export"` makes
`next build` emit plain HTML/CSS/JS into `out/` and production no longer
runs a Next.js server (removing the image optimizer and other server
attack surface).

- next.config.js: output export + images.unoptimized (all images are SVG)
- `pnpm start` now serves `out/` locally
- README: document the static export

Netlify must publish the `out` directory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
next build no longer lints, and build-only failures (e.g. prerender
errors) were not caught by CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
styled-components v6 no longer filters unknown props, so style-only
props (isScrolled, isOpen, isVisible, side, smallPadding, haveMargin,
haveBackground, specialBackground) were forwarded to the DOM as invalid
HTML attributes and triggered React warnings. Prefixing them with `$`
makes styled-components consume them without passing them down.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@netlify

netlify Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for hackupc-landing ready!

Name Link
🔨 Latest commit 9900bfc
🔍 Latest deploy log https://app.netlify.com/projects/hackupc-landing/deploys/6b00ea57d849ee919e3c2a44
😎 Deploy Preview https://deploy-preview-242--hackupc-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@yaoguz

yaoguz commented Nov 21, 2026

Copy link
Copy Markdown
Member

tot ok, pero falta netlify.toml

@yaoguz yaoguz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaoguz
yaoguz merged commit 990c591 into master Nov 21, 2026
5 checks passed
@yaoguz
yaoguz deleted the pnpm-and-nextjs branch November 21, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants