Repository navigation
Migrate to pnpm + Next.js 16 - #242
Merged
Merged
Conversation
- next and @next/third-parties 16.4.5, react/react-dom 19 - @fortawesome/react-fontawesome 0.2 -> 3.5 (0.2 crashes prerender on React 19: className.split on undefined) - bump embla-carousel, html-react-parser, styled-components and typescript within range for React 19 support - tsconfig: jsx react-jsx and .next/dev types, as written by Next 16 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Next 16 removed `next lint` and eslint-config-next 16 requires ESLint 9. - eslint.config.mjs: next core-web-vitals + typescript, react recommended rules and the project's previous custom rules - lint scripts now call the ESLint CLI - drop unused eslint-config-airbnb and deps now provided by eslint-config-next (@typescript-eslint/eslint-plugin, eslint-plugin-import) - CookiesBanner: read consent with useSyncExternalStore instead of setState in an effect (react-hooks/set-state-in-effect) - remove eslint-disable comments that are no longer needed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The site has no server-side features, so `output: "export"` makes `next build` emit plain HTML/CSS/JS into `out/` and production no longer runs a Next.js server (removing the image optimizer and other server attack surface). - next.config.js: output export + images.unoptimized (all images are SVG) - `pnpm start` now serves `out/` locally - README: document the static export Netlify must publish the `out` directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
next build no longer lints, and build-only failures (e.g. prerender errors) were not caught by CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
styled-components v6 no longer filters unknown props, so style-only props (isScrolled, isOpen, isVisible, side, smallPadding, haveMargin, haveBackground, specialBackground) were forwarded to the DOM as invalid HTML attributes and triggered React warnings. Prefixing them with `$` makes styled-components consume them without passing them down. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for hackupc-landing ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
tot ok, pero falta netlify.toml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Next 14 had unpatched vulnerabilities (1 critical remote code execution in Image Optimization, plus DoS and SSRF), and the Dependabot bump broke CI.
Changes
pnpm@12.21.0): dependency install scripts only run if approved, plus a 7-dayminimumReleaseAgeto guard against compromised packages.@fortawesome/react-fontawesomegoes to 3.5, since 0.2 broke the build.eslint.config.mjs), since Next 16 removednext lint. Our custom rules are kept.output: "export"): no Next.js server in production.netlify.toml): builds withpnpm buildand publishesout/..nvmrc, and adds apnpm buildstep.$-prefixed props so they don't end up in the HTML.