Skip to content

HCK-18428: comment out separate comment statements of deactivated columns and tables - #274

Merged
chulanovskyi-bs merged 1 commit into
developfrom
fix/HCK-18428
Nov 4, 2026
Merged

chulanovskyi-bs merged 1 commit into
developfrom
fix/HCK-18428

Conversation

@Sylvie-P

@Sylvie-P Sylvie-P commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Sub-bugHCK-18428 [Oracle, BigQuery, DeltaLake] FE do not comment out the separate comment statements of deactivated columns and tables

## Content

Jira: HCK-18428

With the "Separate" option for table and column comments, the COMMENT ON statements of a deactivated column, or of a deactivated table and its columns, were generated as active statements. They are now commented out, like the column or table itself. Same fix for view comments.

Technical details

  • In "Separate" mode, Studio builds the comment statements from a delta model through the alter-script helpers. The comment DTOs in columnHelpers, entityHelpers and viewHelpers/commentsHelper.js always used isActivated: true.
  • They now use the existing isParentContainerActivated and isObjectInDeltaModelActivated (table flag from role.isActivated), plus the column isActivated for column comments. Same logic as Db2 and PostgreSQL.
  • !== false is used so a missing flag (old models) keeps the statement active.
  • Checked by calling the helpers on a delta collection with an activated and a deactivated table and column. Prettier passes; remaining lint errors in these files are pre-existing.
  • Same fix in BigQuery and Delta Lake. SQL Server was fixed in HCK-18415.

Made with Cursor

…umns and tables

Co-authored-by: Cursor <cursoragent@cursor.com>
@Sylvie-P Sylvie-P self-assigned this Nov 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@chulanovskyi-bs
chulanovskyi-bs merged commit a0a610d into develop Nov 4, 2026
4 of 8 checks passed
@chulanovskyi-bs
chulanovskyi-bs deleted the fix/HCK-18428 branch November 4, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants