Skip to content

fix(rest): format longrunning endpoint honoring universe domain - #16698

Open
scotthart wants to merge 1 commit into
googleapis:mainfrom
scotthart:rest_options_lro_ud
Open

scotthart wants to merge 1 commit into
googleapis:mainfrom
scotthart:rest_options_lro_ud

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@scotthart
scotthart requested a review from a team as a code owner November 21, 2026 00:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the REST options population logic to dynamically resolve the long-running operations endpoint using the configured universe domain via UniverseDomainEndpoint. It also adds comprehensive unit tests in populate_rest_options_test.cc to validate this behavior with various endpoint and universe domain configurations. I have no feedback to provide.

@codecov

codecov Bot commented Nov 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.75%. Comparing base (eb5ee8c) to head (0cca26f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16698   +/-   ##
=======================================
  Coverage   92.74%   92.75%           
=======================================
  Files        2271     2271           
  Lines      227219   227232   +13     
=======================================
+ Hits       210734   210766   +32     
+ Misses      16485    16466   -19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant