Skip to content

fix(rest): format longrunning endpoint honoring universe domain - #16697

Open
scotthart wants to merge 1 commit into
googleapis:v3.14.xfrom
scotthart:patch_ud_lro
Open

scotthart wants to merge 1 commit into
googleapis:v3.14.xfrom
scotthart:patch_ud_lro

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@scotthart
scotthart requested a review from a team as a code owner November 21, 2026 00:30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates PopulateRestOptions to dynamically resolve the long-running operations endpoint using UniverseDomainEndpoint instead of a hardcoded URL. It also adds corresponding unit tests in populate_rest_options_test.cc to verify that the endpoint is correctly constructed when UniverseDomainOption is configured. I have no feedback to provide as the changes are correct and follow the repository's style guidelines.

@codecov

codecov Bot commented Nov 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.63%. Comparing base (1c9bc35) to head (47b1e25).

Additional details and impacted files
@@             Coverage Diff             @@
##           v3.14.x   #16697      +/-   ##
===========================================
- Coverage    92.63%   92.63%   -0.01%     
===========================================
  Files         2271     2271              
  Lines       224833   224846      +13     
===========================================
+ Hits        208272   208277       +5     
- Misses       16561    16569       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants