Repository navigation
Avoid service requests for nonpositive pager limits - #338
Open
vinsymoyya wants to merge 1 commit into
Open
vinsymoyya wants to merge 1 commit into
vinsymoyya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat negative pager limits like zero limits: yield no records and make no service requests. Previously a negative limit stayed truthy as it decreased, so the pager fetched and yielded all available records, potentially sending a negative page size to the service.
Fixes #100.
The new dedicated regression module checks two negative limits, zero, a positive bound, unlimited iteration, and preservation of the caller's request. Both negative cases fail against current master (
468a297c3306f7bb136be918847930580dc3aa7e), while all three controls pass.Validation on Python 3.12:
git diff --checkpass for changed files.