fix(catalogs): name a scheme-less catalog URL instead of reporting "got ://"

src/specify_cli/catalogs.py

@@ -85,8 +85,11 @@ def _validate_catalog_url(cls, url: str) -> None:
             raise cls._error(f"Catalog URL is malformed: {url}") from None
         is_localhost = hostname in ("localhost", "127.0.0.1", "::1")
         if parsed.scheme != "https" and not (parsed.scheme == "http" and is_localhost):
+            # A scheme-less value (``example.com/catalog.json``) would otherwise read
+            # "got ://". The value itself is not echoed: callers render errors as Rich markup.
+            got = f"{parsed.scheme}://" if parsed.scheme else "a URL with no scheme"
             raise cls._error(
-                f"Catalog URL must use HTTPS (got {parsed.scheme}://). "
+                f"Catalog URL must use HTTPS (got {got}). "
                 "HTTP is only allowed for localhost."
             )
         # Check hostname, not netloc: netloc is truthy for host-less URLs like

src/specify_cli/presets/_catalog.py

@@ -133,8 +133,11 @@ def _validate_catalog_url(self, url: str) -> None:
         if parsed.scheme != "https" and not (
             parsed.scheme == "http" and is_localhost
         ):
+            # A scheme-less value (``example.com/catalog.json``) would otherwise read
+            # "got ://". The value itself is not echoed: callers render errors as Rich markup.
+            got = f"{parsed.scheme}://" if parsed.scheme else "a URL with no scheme"
             raise PresetValidationError(
-                f"Catalog URL must use HTTPS (got {parsed.scheme}://). "
+                f"Catalog URL must use HTTPS (got {got}). "
                 "HTTP is only allowed for localhost."
             )
         # Check hostname, not netloc: netloc is truthy for host-less URLs like

src/specify_cli/workflows/catalog/_domain.py

@@ -350,8 +350,11 @@ def _validate_catalog_url(self, url: str) -> None:
         if parsed.scheme != "https" and not (
             parsed.scheme == "http" and is_localhost
         ):
+            # A scheme-less value (``example.com/catalog.json``) would otherwise read
+            # "got ://". The value itself is not echoed: callers render errors as Rich markup.
+            got = f"{parsed.scheme}://" if parsed.scheme else "a URL with no scheme"
             raise WorkflowValidationError(
-                f"Catalog URL must use HTTPS (got {parsed.scheme}://). "
+                f"Catalog URL must use HTTPS (got {got}). "
                 "HTTP is only allowed for localhost."
             )
         if not hostname:

src/specify_cli/workflows/step/catalog/_domain.py

@@ -298,8 +298,11 @@ def _validate_catalog_url(self, url: str) -> None:
         if parsed.scheme != "https" and not (
             parsed.scheme == "http" and is_localhost
         ):
+            # A scheme-less value (``example.com/catalog.json``) would otherwise read
+            # "got ://". The value itself is not echoed: callers render errors as Rich markup.
+            got = f"{parsed.scheme}://" if parsed.scheme else "a URL with no scheme"
             raise StepValidationError(
-                f"Catalog URL must use HTTPS (got {parsed.scheme}://). "
+                f"Catalog URL must use HTTPS (got {got}). "
                 "HTTP is only allowed for localhost."
             )
         if not hostname:

tests/specify_cli/integrations/test_catalog.py

@@ -85,6 +85,12 @@ def test_http_rejected(self):
         with pytest.raises(IntegrationCatalogError, match="HTTPS"):
             IntegrationCatalog._validate_catalog_url("http://example.com/catalog.json")
 
+    def test_schemeless_url_names_the_value(self):
+        with pytest.raises(IntegrationCatalogError) as excinfo:
+            IntegrationCatalog._validate_catalog_url("example.com/catalog.json")
+        assert "(got a URL with no scheme)" in str(excinfo.value)
+        assert "got ://" not in str(excinfo.value)
+
     def test_http_localhost_allowed(self):
         IntegrationCatalog._validate_catalog_url("http://localhost:8080/catalog.json")
         IntegrationCatalog._validate_catalog_url("http://127.0.0.1/catalog.json")

tests/specify_cli/presets/test_catalog.py

@@ -187,6 +187,12 @@ def test_validate_catalog_url_http_rejected(self, project_dir):
         with pytest.raises(PresetValidationError, match="must use HTTPS"):
             catalog._validate_catalog_url("http://example.com/catalog.json")
 
+    def test_validate_catalog_url_schemeless_names_the_value(self, project_dir):
+        """A URL without a scheme is named instead of reported as "got ://"."""
+        catalog = PresetCatalog(project_dir)
+        with pytest.raises(PresetValidationError, match=r"\(got a URL with no scheme\)"):
+            catalog._validate_catalog_url("example.com/catalog.json")
+
     def test_validate_catalog_url_localhost_http_allowed(self, project_dir):
         """Test that HTTP is allowed for localhost."""
         catalog = PresetCatalog(project_dir)

tests/test_workflows.py

@@ -10349,6 +10349,17 @@ def test_validate_url_http_rejected(self, project_dir):
         with pytest.raises(WorkflowValidationError, match="HTTPS"):
             catalog._validate_catalog_url("http://evil.com/catalog.json")
 
+    def test_validate_url_schemeless_names_the_value(self, project_dir):
+        from specify_cli.workflows.catalog import WorkflowCatalog, WorkflowValidationError
+        from specify_cli.workflows.step.catalog import StepCatalog, StepValidationError
+
+        for catalog, error in (
+            (WorkflowCatalog(project_dir), WorkflowValidationError),
+            (StepCatalog(project_dir), StepValidationError),
+        ):
+            with pytest.raises(error, match=r"\(got a URL with no scheme\)"):
+                catalog._validate_catalog_url("example.com/catalog.json")
+
     def test_validate_url_localhost_http_allowed(self, project_dir):
         from specify_cli.workflows.catalog import WorkflowCatalog