Skip to content

fix: block option interaction when an open select is disabled - #552

Merged
ghiscoding merged 1 commit into
ghiscoding:mainfrom
Xapollon430:codex/guard-disabled-open-selection
Nov 10, 2026
Merged

ghiscoding merged 1 commit into
ghiscoding:mainfrom
Xapollon430:codex/guard-disabled-open-selection

Conversation

@Xapollon430

Copy link
Copy Markdown
Contributor

Summary

Calling disable() while a Multiple Select menu is open disables the trigger, but clicking an option still changes the selection and emits a change event.

  1. Open an enabled Multiple Select.
  2. Call disable() while the list is open.
  3. Click an unselected option. In the recording, Orange is added even though the control is disabled.

Recorded in Chromium against the upstream code at b055f03.

multiple-select-vanilla-disabled.mp4

Changes

Make the dropdown inert while the control is disabled. Calling enable() restores interaction. The regression checks both transitions with a real browser click.

Validation

The Chromium Methods 04 tests, the TypeScript build and Biome checks, and the package security tests passed.

AI / LLM assistance

Codex helped reproduce the bug, implement the fix, and verify the regression.

@github-actions

Copy link
Copy Markdown

Playwright E2E Test Results

109 tests  +1   109 ✅ +1   1m 37s ⏱️ -4s
 77 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 528edcd. ± Comparison against base commit b055f03.

@ghiscoding

Copy link
Copy Markdown
Owner

good catch, thanks a lot, I verified it with Astra and it seems all good

@ghiscoding
ghiscoding merged commit 5089939 into ghiscoding:main Nov 10, 2026
4 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This pull request is included in version 5.2.6 📦
🔗 The release notes are available at: GitHub Release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants