Skip to content

fix(search-events): Report the query's timestamp bounds as the time range - #2466

Draft
sentry-junior[bot] wants to merge 1 commit into
mainfrom
fix/search-structured-timestamp-time-range
Draft

sentry-junior[bot] wants to merge 1 commit into
mainfrom
fix/search-structured-timestamp-time-range

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 22, 2026

Copy link
Copy Markdown
Contributor

Fixes #2465.

A structured search with an explicit dataset, fields and sort skips the embedded agent. On that path the handler sent only statsPeriod, even when the query named an absolute window with timestamp:>= / timestamp:<. Sentry still applied the bounds in the query, so the results were right. But the executed search said "Time range: Last 7d", and the structured result had start/end null.

The same window through the agent path reports start/end, because the agent moves the bounds into timeRange. A caller reproducing an alert window got samples that said one window and aggregates that said another.

Change

On the no-agent path, the period is narrowed to the query's top-level timestamp: bounds. This reuses the overlap logic the agent path already applies to the agent's range (renamed narrowPeriodToAgentRange → narrowPeriodToRange, since it now takes either range). The bounds stay in the query, and they only narrow the period, so the rows don't change. A lower bound with no upper bound runs until now. Bounds that aren't absolute ISO timestamps with a Z or an offset are ignored. Boolean or grouped queries are left alone, because a bound inside a group doesn't bound the whole search.

Overlap with #2139: that draft adds a QUOTED_VALUE_PATTERN constant with the same name and regex to search.ts. Whichever PR lands second should reuse the other's.

via automation evt_905b9c478746fd9deeb853f85ad7441b · Run ID dispatch_b2d88ec2d0f24acdeb3743666e8717ab.

--

View Session [Sentry]

…ange

Structured searches that skip the embedded agent (explicit dataset, fields
and sort) sent only statsPeriod, even when the query named an absolute
window with timestamp:>= / timestamp:< bounds. The results were bounded by
the query, but the executed search reported "Last 7d" with start/end null.
Agent-translated searches over the same window reported start/end, so the
same window was described two ways.

Narrow the period to the query's top-level timestamp bounds on this path,
as the agent path already does with the agent's range. Grouped or boolean
queries are left as they are.
@vercel

vercel Bot commented Nov 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cli Ready Ready Preview Nov 22, 2026 5:25pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
sentry-local Skipped Skipped Nov 22, 2026 5:25pm UTC

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

📊 MCP Server Token Cost Report

Summary

  • Total Tokens: 65205 tokens
  • Tool Count: 74 tools
  • Average: 881 tokens/tool

Per-Tool Breakdown

Tool Tokens % of Total
get_issue_details 3938 6%
get_alert_rule 2245 3.4%
find_releases 1805 2.8%
get_issue_activity 1759 2.7%
update_alert_rule 1653 2.5%
get_replay_details 1602 2.5%
create_alert_rule 1506 2.3%
get_monitor_details 1501 2.3%
update_metric_monitor 1479 2.3%
create_metric_monitor 1458 2.2%
get_event_stacktrace 1381 2.1%
update_issue 1380 2.1%
get_snapshot 1308 2%
get_profile 1291 2%
get_agent_conversation_details 1278 2%
find_monitors 1261 1.9%
search_logs 1248 1.9%
search_traces 1246 1.9%
get_alert_options 1236 1.9%
search_profiles 1228 1.9%
search_metrics 1216 1.9%
search_errors 1214 1.9%
get_profile_details 1200 1.8%
get_uptime_monitor_details 1163 1.8%
create_monitor 1135 1.7%
onboarding_status_update 1109 1.7%
search_issue_events 1103 1.7%
search_replays 1095 1.7%
find_related_issues 1068 1.6%
get_release_details 1056 1.6%
get_dashboard_details 1052 1.6%
search_issues 977 1.5%
search_docs 973 1.5%
find_alert_rules 908 1.4%
update_uptime_monitor 873 1.3%
create_uptime_monitor 871 1.3%
search_agent_conversations 830 1.3%
find_dropped_events 819 1.3%
get_metric_monitor_details 797 1.2%
create_project 793 1.2%
update_dsn 765 1.2%
get_issue_user_reports 630 1%
get_latest_base_snapshot 623 1%
find_dashboards 553 0.8%
link_issue 545 0.8%
find_uptime_monitors 537 0.8%
get_issue_breadcrumbs 492 0.8%
unlink_issue 476 0.7%
find_metric_monitors 471 0.7%
get_issue_tag_values 469 0.7%
update_project 441 0.7%
get_sentry_resource 429 0.7%
submit_feedback_to_sentry_team 426 0.7%
add_issue_note 404 0.6%
delete_monitor_environment 363 0.6%
find_teams 351 0.5%
find_projects 346 0.5%
delete_alert_rule 345 0.5%
delete_uptime_monitor 333 0.5%
delete_metric_monitor 331 0.5%
create_dsn 326 0.5%
add_team_to_project 324 0.5%
remove_team_from_project 320 0.5%
find_dsns 319 0.5%
find_organizations 311 0.5%
get_snapshot_image 302 0.5%
analyze_issue_with_seer 300 0.5%
get_event_attachment 299 0.5%
get_trace_details 282 0.4%
create_team 266 0.4%
get_span_details 263 0.4%
whoami 261 0.4%
get_sentry_mcp_info 142 0.2%
get_doc 102 0.2%

Note: This measures the static overhead of tool definitions sent to LLM clients with every request. Lower is better.

MCP Apps views

Each ui:// view as a host receives it from resources/read.

View MIME type Raw Gzip Brotli Budget % of budget
ui://sentry/chart/v5.html text/html;profile=mcp-app 19,234 B 7,915 B 7,020 B 24,576 B 78.3%

The budget applies to raw bytes, and the view's generator fails over it.

This branch was successfully deployed

2 active and 1 inactive deployments
Actions — 16055ec5 Deployed Nov 22, 2026 by sentry-junior[bot] via eval #2024
Preview – cli — 16055ec5 Deployed Nov 22, 2026 by vercel[bot]
Preview – sentry-local — 16055ec5 Deployed Nov 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Structured searches that skip the agent report the whole period instead of the query's timestamp window

0 participants