Skip to content

fix(search-events): Drop the non-null assertion that fails lint on main - #2277

Merged
MathurAditya724 merged 1 commit into
mainfrom
fix/search-events-unnecessary-assertion
Nov 15, 2026
Merged

MathurAditya724 merged 1 commit into
mainfrom
fix/search-events-unnecessary-assertion

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Removes the ! from return requests[0]!; in the search-events tests. #2146 added it on a branch that predates #2125, which made unnecessary type assertions an error, so main has rejected it since 88c26a3e.

The return type is still URLSearchParams. Nothing else changes.

via @MathurAditya724.

--

View Session [Sentry]

#2146 ran CI before #2125 enabled
typescript/no-unnecessary-type-assertion, so `requests[0]!` in its test
landed on main and now fails `pnpm lint`.

Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
@vercel

vercel Bot commented Nov 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
sentry-local Skipped Skipped Nov 15, 2026 7:55am UTC

Request Review

@MathurAditya724
MathurAditya724 marked this pull request as ready for review November 15, 2026 07:56
@github-actions github-actions Bot added the risk: low PR risk score: low label Nov 15, 2026
@MathurAditya724
MathurAditya724 enabled auto-merge (squash) November 15, 2026 07:57
@MathurAditya724
MathurAditya724 merged commit cfd76ae into main Nov 15, 2026
35 checks passed
@MathurAditya724
MathurAditya724 deleted the fix/search-events-unnecessary-assertion branch November 15, 2026 08:06

This branch was successfully deployed

1 active and 1 inactive deployments
Actions — 7980a434 Deployed Nov 15, 2026 by sentry-junior[bot] via eval #1915
Preview — 7980a434 Deployed Nov 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant