Repository navigation
Conversation
Litarnus
force-pushed
the
manual-pause-resume
branch
from
November 3, 2026 16:51
2f481fc to
ed98285
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ed98285. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Introduces pausing and resuming a manual profiling session. For long living runtimes such as FrankenPHP or Swoole, there might be a time where the runtime simply waits for a next request to handle. By design, the process doesn't terminate which means that Excimer is still running and producing samples. This will then look like the last call took a very long time.
By calling
pauseandresumeat request boundaries, we are able to inject idle samples which will signal a stop to the previous sampled call. Internally it's solved through a request reference counting, so even if the runtimes is async, it will only pause if no other request is currently in-flight.