Skip to content

fix(ios): Preserve executable bits in distribution IPAs - #756

Open
lcian wants to merge 2 commits into
mainfrom
lcian/fix/preserve-ipa-executables
Open

lcian wants to merge 2 commits into
mainfrom
lcian/fix/preserve-ipa-executables

Conversation

@lcian

@lcian lcian commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Build Distribution can generate an IPA whose app and framework binaries have lost their executable bits. This change restores those bits from the uploaded XCArchive when packaging the IPA.

The companion CLI fix preserves the source attributes when converting an IPA upload into an XCArchive. getsentry/toolkit#2461

@sentry

sentry Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Size Analysis

1 component analyzed, 1 component processing

iOS Builds

Name Configuration Version Download Size Install Size
HackerNews (iOS)
com.emergetools.hackernews
Release 3.8 (1) 6.5 MB (N/A) 9.7 MB (N/A)

Android Builds

Name Configuration Version Download Size Uncompressed Size
Hacker News (Android)
com.emergetools.hackernews
Release 1.0.2 (13) Processing... (-) Processing... (-)

Configure launchpad-test-ios status check rules

@sentry

sentry Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
HackerNews com.emergetools.hackernews 3.8 (1) Release

Android

🔗 App Name App ID Version Configuration
Hacker News com.emergetools.hackernews 1.0.2 (13) Release

⚙️ launchpad-test-android Build Distribution Settings

@lcian
lcian marked this pull request as ready for review November 21, 2026 19:47
Zip member names are untrusted, so resolve them against the extraction directory instead of building raw paths from them.
@lcian
lcian requested a review from a team November 21, 2026 20:04
@lcian
lcian enabled auto-merge (squash) November 21, 2026 20:04
BYK pushed a commit to getsentry/toolkit that referenced this pull request Nov 22, 2026
Uploading an IPA drops the Unix permissions on its app and framework
binaries. This change carries each file's type and permission bits from
the IPA into the XCArchive sent to Build Distribution.

The CLI now reads the attributes from the central directory and
continues to stream the file contents through temporary files. An IPA
with more than 65,535 entries did not upload before this change and
still does not, but now fails with a validation error instead of a raw
`RangeError`.

The server-side fix preserves those bits when generating the installable
IPA. getsentry/launchpad#756

---------

Co-authored-by: Codex CLI Agent <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant