Repository navigation
DXP-1370: Document Vitest instead of Jest in CONTRIBUTING.md - #447
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
danieljrc888
left a comment
There was a problem hiding this comment.
Reviewed at 8eb8d2d. Docs only. I checked each statement against the repo: vitest.config.ts (globals, jsdom, tests/setup.ts, 10s timeout, the two excludes), the test, test:watch, test:coverage and test:smoke scripts, and @vitest/coverage-v8 in devDependencies. All match. Approving.
What
Rewrites the "Run unit tests" section of
CONTRIBUTING.md, which described Jest, ts-jest andjest.config.js, to describe the Vitest setup the repo uses (vitest.config.ts,npm run test=vitest, plus thetest:watch,test:coverageandtest:smokescripts).Ticket: DXP-1370
Testing
Docs-only change.
npm ci --ignore-scriptsthenvitest run: 831 tests pass in 77 files. One suite (tests/libs/keychainManager.test.ts) could not load because the nativekeytarmodule was not built, which is a side effect of--ignore-scriptsin my sandbox and unrelated to this change. Docker/CI not run.Assumptions
npm run testas watch mode (it isvitest) and addednpx vitest runfor a single run.vitest.config.ts(globals, jsdom, setup file, 10s timeout, excludes).jest.config.jsentry ineslint.config.jsignores untouched to keep the change docs-only.support/ci/ACTIVE_DEV_BRANCHonv0.41-devstill saysv0.40-dev; not touched.🤖 Generated with Claude Code