Skip to content

DXP-1370: Document Vitest instead of Jest in CONTRIBUTING.md - #447

Merged
danieljrc888 merged 1 commit into
v0.41-devfrom
legatus/dxp-1370
Nov 20, 2026
Merged

danieljrc888 merged 1 commit into
v0.41-devfrom
legatus/dxp-1370

Conversation

@jmlago

@jmlago jmlago commented Nov 20, 2026

Copy link
Copy Markdown
Member

What

Rewrites the "Run unit tests" section of CONTRIBUTING.md, which described Jest, ts-jest and jest.config.js, to describe the Vitest setup the repo uses (vitest.config.ts, npm run test = vitest, plus the test:watch, test:coverage and test:smoke scripts).

Ticket: DXP-1370

Testing

Docs-only change. npm ci --ignore-scripts then vitest run: 831 tests pass in 77 files. One suite (tests/libs/keychainManager.test.ts) could not load because the native keytar module was not built, which is a side effect of --ignore-scripts in my sandbox and unrelated to this change. Docker/CI not run.

Assumptions

  • Documented npm run test as watch mode (it is vitest) and added npx vitest run for a single run.
  • Listed the config values from vitest.config.ts (globals, jsdom, setup file, 10s timeout, excludes).
  • Left the stale jest.config.js entry in eslint.config.js ignores untouched to keep the change docs-only.
  • support/ci/ACTIVE_DEV_BRANCH on v0.41-dev still says v0.40-dev; not touched.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f2e7d7f1-3667-4dba-97ad-65f5a29993b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@danieljrc888 danieljrc888 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 8eb8d2d. Docs only. I checked each statement against the repo: vitest.config.ts (globals, jsdom, tests/setup.ts, 10s timeout, the two excludes), the test, test:watch, test:coverage and test:smoke scripts, and @vitest/coverage-v8 in devDependencies. All match. Approving.

@danieljrc888
danieljrc888 merged commit f530187 into v0.41-dev Nov 20, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants