Skip to content

fix: interpret bare multipole strengths as Tesla - #195

Merged
maureeungaro merged 1 commit into
gemc:mainfrom
zhaozhiwen:fix/186-field-units
Nov 18, 2026
Merged

maureeungaro merged 1 commit into
gemc:mainfrom
zhaozhiwen:fix/186-field-units

Conversation

@zhaozhiwen

Copy link
Copy Markdown
Collaborator

Bare 1 gave 1000 T.

Scale only unitless local field strengths; explicit units and the shared number parser retain their behavior.

Validation: Bare/explicit units, negative and zero values, shifted origin and dipole rotation. Regression failed against the original implementation and passed with the focused fix. Combined source build/install and all 44 affected regressions passed. The 32-example sweep retained its 19/32 baseline with no new failing examples.

Closes #186.

Verification on 2026-11-15: all 44 selected affected regressions passed again on the combined nine-fix source. Each issue also has a separate failing-original/passing-fixed regression. These PR branches each contain only their own fix; shared-file conflicts may need resolving as other fixes merge. No clean full-project-suite claim: the broader source-example baseline remains 19/32, with no newly failing examples in the combined sweep.

@maureeungaro maureeungaro self-assigned this Nov 18, 2026
@maureeungaro maureeungaro added the documentation Improvements or additions to documentation label Nov 18, 2026
@maureeungaro maureeungaro added this to the GEMC Version 0.6 milestone Nov 18, 2026
@maureeungaro
maureeungaro merged commit 3716d73 into gemc:main Nov 18, 2026
54 of 58 checks passed
@github-project-automation github-project-automation Bot moved this to Current Milestones Done in gemc3 Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Current Milestones Done

Development

Successfully merging this pull request may close these issues.

Documented bare multipole strengths are interpreted as 1000 times the intended Tesla value

2 participants