Skip to content

Magic.gi: use InfoAutoDoc instead of Print - #391

Merged
fingolfin merged 1 commit into
gap-packages:masterfrom
mtorpey:remove-print-statements
Nov 13, 2026
Merged

fingolfin merged 1 commit into
gap-packages:masterfrom
mtorpey:remove-print-statements

Conversation

@mtorpey

@mtorpey mtorpey commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

These hard-coded prints make testing harder, for example in PackageManager.

@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.08%. Comparing base (f468f4b) to head (140a02d).

Files with missing lines Patch % Lines
gap/Magic.gi 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   93.11%   93.08%   -0.03%     
==========================================
  Files          15       15              
  Lines        3179     3180       +1     
==========================================
  Hits         2960     2960              
- Misses        219      220       +1     
Files with missing lines Coverage Δ
gap/Magic.gi 75.29% <0.00%> (-0.18%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtorpey

mtorpey commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this is only failing because of codecov – I only modified lines that were already untested, so I hope that won't be a barrier.

@fingolfin
fingolfin merged commit bd44b5e into gap-packages:master Nov 13, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants