Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjacencyrejects an adjoinedSequenceLocationthat has bothstartandend, but the check uses truthiness, so a bound of0counts as missing:start=0is a valid position (the minimum allowed bySequenceLocation), so a location starting at the beginning of a sequence, or ending at 0, gets past the validator. The check now usesis not Nonefor both bounds. This is the same kind of0-is-falsy problem as #688 innormalize.Tests
test_adjacencyintests/validation/test_models.pynow also checks(start, end)of(0, 2),(1, 0)and(0, 0). They fail onmain(noValueErrorraised) and pass with this change; the existing valid cases still pass.ruff checkandruff format --check(v0.9.4) are clean. The rest of the suite passes locally, except tests that need a local SeqRepo at/usr/local/share/seqrepo(test_dataproxy,test_vrs_normalize).