Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ga4gh_enrefkeeps a single referable attribute that is already a reference (a string oririReference) and checks that it is a GA4GH identifier. The list branch skips that check and calls_enrefon every item, so a list that already holds references fails:The reference check is now a small
_is_referencehelper used by both branches. List items that are already references are kept as they are, and a non-GA4GH CURIE in a list raises the sameTypeErroras a single attribute does. Inlined list items are enref'd as before. The single-attribute behaviour is unchanged.Tests
test_enref_list_attribute_with_referencesintests/test_vrs.pyenrefs an already-enref'dCisPhasedBlock, enrefs a block with one referenced and one inlined member, and checks theTypeErrorfor a non-GA4GH CURIE member. It fails onmainwith theAttributeErrorabove and passes with this change.ruff checkandruff format --check(v0.9.4) are clean. The rest of the suite passes locally, except tests that need a local SeqRepo at/usr/local/share/seqrepo(test_dataproxy,test_vrs_normalize).This is independent of #698, which fixes the matching list branch in
ga4gh_deref.