Repository navigation
Fit the docs to phones and reserve each screenshot's box - #223
Merged
Merged
Conversation
The top bar pushed the menu button off a 320px phone. Copy Markdown and the page navigation were under 44px. Pages jumped when a screenshot arrived on a slow connection. This PR fixes the bar and sizes those controls from one `--fs-tap-target` token. The Markdown build now adds each screenshot's width and height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top bar pushed the menu button off a 320px phone. Copy Markdown and the page navigation were under 44px. Pages jumped when a screenshot arrived on a slow connection. This PR fixes the bar and sizes those controls from one
--fs-tap-targettoken. The Markdown build now adds each screenshot's width and height.Theme sidebar links and the 404 link stay at 32px, as the new DESIGN.md states. The Framer example screenshot is lighter. Page content does not change.