Skip to content

Ride the Ruby tier's cdylib (ext/fontisan_cdylib) and its engine pin - #1

Merged
HassanAkbar merged 3 commits into
mainfrom
lane/75-01-ride-the-ruby-tier-s-cdylib-ext-fontisan
Nov 16, 2026
Merged

HassanAkbar merged 3 commits into
mainfrom
lane/75-01-ride-the-ruby-tier-s-cdylib-ext-fontisan

Conversation

@HassanAkbar

Copy link
Copy Markdown
Member

Ride the Ruby tier's cdylib (ext/fontisan_cdylib) and its engine pin

Part of fontist/fontisan#166: Python face: fontisan-python — C-ABI cdylib rider (parsanol-python pattern)

Problem

Fontisan-python builds fontisan-rs fontisan-ffi at 614dca3, but the Ruby:ffi tier builds fontisan's ext/fontisan_cdylib pinned to f45057a. That is a second build at a different engine rev, and because fontisan-ffi exports no fontisan_cdylib_engine_rev, Python relies on a stamp file instead.

Fix

  • Build the cdylib from fontisan's ext/fontisan_cdylib at a pinned fontisan rev (a new FONTISAN_REV file), not from fontisan-rs fontisan-ffi
  • Derive ENGINE_REV from that crate's fontisan-rs git rev; the loader checks the exported fontisan_cdylib_engine_rev against it and drops the stamp-file fallback
  • Load lib name fontisan_cdylib (.so/.dylib/.dll) in _ffi.py and stage_cdylib.py; update package-data globs, README and both workflows' build steps

Done when

  • tests/test_binding.py passes against a cdylib built from ext/fontisan_cdylib, including a spec that a cdylib exporting a different engine rev is refused
  • fontisan.engine_rev equals the rev in fontisan's ext/fontisan_cdylib/Cargo.toml at the pinned fontisan rev

check.rb:
Warning! PATH is not properly set up, /Users/umerhassan/.rvm/gems/ruby-3.4.8/bin is not at first place.
Usually this is caused by shell initialization files. Search for PATH=... entries.
You can also re-add RVM to your profile by running: rvm get stable --auto-dotfiles
To fix it temporarily in this shell session run: rvm use ruby-3.4.8
To ignore this error add rvm_silence_path_mismatch_check_flag=1 to your ~/.rvmrc file.
specs: SKIP (no lib or spec changes)

@HassanAkbar

Copy link
Copy Markdown
Member Author

@ribose-cla agree icla

@ribose-cla

ribose-cla Bot commented Nov 16, 2026

Copy link
Copy Markdown

@HassanAkbar recorded — this pull request is contributed under the Individual CLA v1.0. The check re-ran and reflects it.

@HassanAkbar
HassanAkbar merged commit a0a393a into main Nov 16, 2026
12 checks passed
@ribose-cla

ribose-cla Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

CLA attribution for this merged contribution

  • @HassanAkbar — this work is submitted under an existing Ribose agreement; the CLA process does not apply.

Elections recorded during review:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant