Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces configuration options to control whether email sign-up requires a display name and whether new email accounts can be created. It updates AuthService with new parameters, adds a display name input field to the sign-up UI, introduces a new error case for disallowed sign-ups, and updates the corresponding tests and documentation. There are no review comments provided, so I have no additional feedback to offer.
demolaf
force-pushed
the
auth/email-signup-options
branch
from
November 9, 2026 15:41
63cb099 to
2bd8362
Compare
demolaf
marked this pull request as ready for review
November 10, 2026 14:25
Restores the FirebaseUI-iOS v15 email options. withEmailSignIn takes requireDisplayName (default true) and allowNewEmailAccounts (default true). EmailAuthContentState gains a displayName binding and requiresDisplayName and canSignUp flags, the stock form asks for a name on sign-up and hides the sign-up switch when sign-up is off, and createUser saves the name after creating or upgrading the account and throws emailSignUpNotAllowed when sign-up is off.
createUser reported the new account authenticated before saving its display name, and a failed save left the state unchanged. Save the name first and update the state either way. The stock Name field now rejects whitespace-only names with a message, matching isValid, and the docs note that email-link sign-in still creates accounts while sign-up is off.
Default requireDisplayName to false so the stock sign-up form is unchanged unless an app opts in, and refuse sign-up with Firebase's own adminRestrictedOperation error instead of a new AuthServiceError case, which would break exhaustive switches.
…eUser(email:password:) The error thrown while sign-up is off now carries Firebase's error name and a localized message, so apps that read either get the same values as for the error Firebase returns. Restore the two-argument createUser so references to it still compile, and test that email sign-in doesn't require a name by default.
demolaf
force-pushed
the
auth/email-signup-options
branch
from
November 10, 2026 15:56
3e1cd26 to
d2d9a6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the v15 email sign-up options: sign-up can ask for a name and save it as the display name, and apps can turn sign-up off. Builds on #1414, so custom email screens get the new fields before the slot API ships.
Changes
withEmailSignIn(requireDisplayName:allowNewEmailAccounts:).requireDisplayNamedefaults tofalseso existing apps see no change (v15 and Android default totrue);allowNewEmailAccountsdefaults totrue.EmailAuthContentStategains adisplayNamebinding plusrequiresDisplayNameandcanSignUp, all with init defaults.isValidneeds a non-blank name on sign-up when one is required.createUser(email:password:displayName:)saves the name before reporting the account signed in, and throws Firebase's ownadminRestrictedOperationwhen sign-up is off, soAuthServiceErroris unchanged.API Usage
Preview
Maintainer note: Fixes internal CPRN-638, fixes internal CPRN-639