Skip to content

Lint the generated stylesheets, now that they pass - #277

Merged
amjadr360 merged 1 commit into
mainfrom
improvement/lint-generated-css
Nov 16, 2026
Merged

amjadr360 merged 1 commit into
mainfrom
improvement/lint-generated-css

Conversation

@amjadr360

Copy link
Copy Markdown
Contributor

The stylesheets the design source generates for this theme were skipped by Stylelint, because fixing them here was pointless: the next sync overwrote the fix. They are now written to the WordPress Stylelint rules at the source, so the theme stops skipping them and npm run lint:css covers every stylesheet again.

The synced woocommerce.css also carries a real fix that was waiting for this: on a dark palette, WooCommerce's classic login, register and lost-password fields stayed white, and the variation dropdown drew a black arrow on a dark field. They now follow the site's colours. The retired-names block in style.css changes only in spelling.

Screenshots

1. The account page's fields on a dark palette

account fields dark

2. The variation dropdown on a dark palette: WooCommerce's own black arrow becomes the native one

variation select dark

3. A light palette, for the regression: the fields now take the page's own surface and border

account fields light

Checked on WordPress 7.1 with WooCommerce, on a light and a dark palette: shop, product, cart, home and the account page. Everything apart from these fields and that arrow is pixel-for-pixel unchanged.

PR description generated by Claude.

The design source now writes woocommerce.css, hide-block-presets.css,
masteriyo.css and the retired-names block to the WordPress Stylelint
rules, so the theme stops skipping them. The synced woocommerce.css
also brings the fix for Woo's classic login and register fields and
the variation select on dark palettes; the retired-names block changes
only in spelling.
@amjadr360
amjadr360 marked this pull request as ready for review November 16, 2026 06:29
@amjadr360
amjadr360 merged commit 31ad56d into main Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant