Repository navigation
Lint the generated stylesheets, now that they pass - #277
Merged
Merged
Conversation
The design source now writes woocommerce.css, hide-block-presets.css, masteriyo.css and the retired-names block to the WordPress Stylelint rules, so the theme stops skipping them. The synced woocommerce.css also brings the fix for Woo's classic login and register fields and the variation select on dark palettes; the retired-names block changes only in spelling.
amjadr360
marked this pull request as ready for review
November 16, 2026 06:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stylesheets the design source generates for this theme were skipped by Stylelint, because fixing them here was pointless: the next sync overwrote the fix. They are now written to the WordPress Stylelint rules at the source, so the theme stops skipping them and
npm run lint:csscovers every stylesheet again.The synced
woocommerce.cssalso carries a real fix that was waiting for this: on a dark palette, WooCommerce's classic login, register and lost-password fields stayed white, and the variation dropdown drew a black arrow on a dark field. They now follow the site's colours. Theretired-namesblock instyle.csschanges only in spelling.Screenshots
1. The account page's fields on a dark palette
2. The variation dropdown on a dark palette: WooCommerce's own black arrow becomes the native one
3. A light palette, for the regression: the fields now take the page's own surface and border
Checked on WordPress 7.1 with WooCommerce, on a light and a dark palette: shop, product, cart, home and the account page. Everything apart from these fields and that arrow is pixel-for-pixel unchanged.
PR description generated by Claude.