Repository navigation
feat: add an option to ignore empty body updates - #60
Conversation
Workaround for a vscode quirk. Closes exteditor#23
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Define and deliver the option src/ghosttext-adaptor/api.ts, src/ghosttext-runner/api.ts, ext/options.html, ext/options.css, locales.toml, src/ghosttext-adaptor/client_options_loader.ts, src/test/testbench/ghostbird.ts |
The options form adds a localized checkbox. The option is added to StoredOptions and ClientOptions. ClientOptionsLoader loads the stored value, defaults it to false, and includes it in the returned options. |
Apply the option to outgoing edits src/ghosttext-adaptor/email_editor.ts |
EmailEditor skips sending an edit when the option is enabled and the body is empty. Tests cover empty and non-empty bodies with the option enabled or disabled. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Feature
Sequence Diagram(s)
sequenceDiagram
participant Caller
participant EmailEditor
participant SendCallback
Caller->>EmailEditor: applyChange(change)
EmailEditor->>EmailEditor: Check option and change.body
alt Option enabled and body is empty
EmailEditor-->>Caller: Return without sending
else Option disabled or body is non-empty
EmailEditor->>SendCallback: Send edit
end
Merge Risk: 
Minimal · up to 353de
-
No merge-blocking risk was identified in the option wiring or empty-body handling.
Pre-merge checks: 
3 · 
2
-
Failed checks: 2 warnings Passed checks: 3 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 5 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the message flow,
An empty body need not go.
The setting keeps that choice in view,
Full messages still travel through.
The rabbit hops and calls it done.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Workaround for a vscode quirk (see #23).