Repository navigation
deps: bump pragmarx/google2fa to 9 and refresh composer.lock - #128
Merged
Merged
Conversation
google2fa 9's only breaking change is the default secret length (16 -> 32); TwoFactorService already asks for 32 explicitly. Dependabot cannot see this repo's updates (escalated-locale VCS repository), so the lock is refreshed by hand as well: onelogin/php-saml 4.4.1 (xmlseclibs 4, phpseclib 3), constant_time_encoding 3.1.4, phpunit 9.6.38. Supersedes #120.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pragmarx/google2fa^8.0 -> ^9.1 (supersedes chore(deps): bump pragmarx/google2fa from 8.0.3 to 9.1.0 #120, which is behind main). The v9 breaking change is the default secret length 16 -> 32;TwoFactorService::generateSecret()already passes 32, andverifyKey/verifyKeyNewer/oathTotpare unchanged.composer audit: clean. Pint passes.