Repository navigation
Say a report's task is settled once, however often it waits - #56
Merged
Merged
Conversation
A report of a task settled before GOA took it is told with a note saying so (#53). The note was added each time the line was handed out, and a line GOA couldn't take yet goes back to wait with it in its text, so the note came again at each try: in goa-tell.json and in what GOA was finally told. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: enowdev <enowdev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #53 (change 6, "Tell GOA a report even once its task is settled").
What was wrong. A report of a task settled before GOA took it is told with a note: "(Its task is settled already: nothing to settle, only to read.)".
goaLinesToSayadded that note to the line's text each time it handed the line out (daemon/goa.go). A line GOA can't take yet goes back to wait with the note already in it:goaFlushwhen the composer isn't sure to be empty (daemon/goa_inject.go), andgoaTakeAtStop(daemon/goa_stop.go). So each later try added the note again. It piled up ingoa-tell.jsonand in what GOA was finally told, most of all where GOA can't be typed into for a long time.Fix. The note is added only when the text doesn't already end with it.
TestGOASettledNoteSaidOnceputs a settled report back three times and expects the note exactly once. It fails without the fix (the note shows three times).Tested:
nice -n 15 go test -p 2 ./daemon/...passes;go vet ./daemonandGOOS=windows go vet ./daemonare clean.Separately:
TestImageMentionMouseSelection, red on ubuntu in #53's last CI run, looks flaky, not broken. On main (e9094a5),go test ./ui/notesview -count=20 -run TestImageMentionMouseSelectionpassed 20 of 20, twice (40 runs). It also passed on ubuntu in #54's CI, which is based on the same main. I didn't change it here; the CI failure was the click not selecting the mention (image_blocks_test.go:170, an empty rect), which suggests a timing issue in the CI runner. That is inferred from the output, not reproduced.🤖 Generated with Claude Code