Repository navigation
Remove unused compute_feature_lists - #179
Merged
Merged
Conversation
Delete features/make_cc_features.bzl, which nothing loads and which calls undefined helpers. Remove the body-less compute_feature_lists stub from features/custom/qnx/make_cc_features.bzl. Point the BUILD.template comment at get_feature_lists(), the function the template actually loads.
nradakovic
added
p4
nradakovic
requested review from
antonkri,
dcalavrezo-qorix and
odra
as code owners
November 3, 2026 06:52
5 tasks
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the unused-code cleanup and template documentation update.
No open issues 🎉
What changed in this PR
Removes unused compute_feature_lists code and aligns the template documentation with the existing get_feature_lists() entry point.
Changes:
- Deletes the unused shared helper that calls undefined functions.
- Removes the docstring-only QNX stub.
- Corrects the BUILD template comment without changing its behavior.
| File | Description |
|---|---|
templates/BUILD.template |
Updates the comment to reference get_feature_lists(). |
features/make_cc_features.bzl |
Deletes the unused shared helper file. |
features/custom/qnx/make_cc_features.bzl |
Removes the unused compute_feature_lists stub. |
Review effort: Balanced
AlexanderLanin
approved these changes
Nov 3, 2026
github-project-automation
Bot
moved this from in review
to Done
in INF - Infrastructure Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete features/make_cc_features.bzl, which nothing loads and which calls undefined helpers. Remove the body-less compute_feature_lists stub from features/custom/qnx/make_cc_features.bzl.
Point the BUILD.template comment at get_feature_lists(), the function the template actually loads.