Skip to content

fix: let visitors retry failed Pulse Check loads - #150

Merged
johnnyhuy merged 2 commits into
mainfrom
agent/issue-149-pulse-check-retry
Nov 16, 2026
Merged

johnnyhuy merged 2 commits into
mainfrom
agent/issue-149-pulse-check-retry

Conversation

@johnnyhuy

Copy link
Copy Markdown
Contributor

Pulse Check now offers Retry after a failed catalog load, announces loading while the next request is pending, and restores the existing sample dashboard on success. Another failure keeps recovery available; the sample-data notice stays visible in every state.

Part of #85
Closes #149

Verified in this worktree

  • MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run install passed with peer-dependency warnings and no lockfile changes.
  • MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run lint passed TypeScript and ESLint across all five workspaces.
  • MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run test -- --runInBand --verbose passed 71 tests in 10 suites, with one existing skipped test and suite.
  • BROWSER=none MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run dev compiled successfully and initialised the backend plugins. /pulse-check returned HTTP 200. The dev stack was stopped after verification.
  • git diff --check origin/main...HEAD passed.
  • mise run build was not run locally because this slice changes frontend controls and component tests only. The PR Build workflow runs all four mise gates, including the Docker image build.

Screenshot method (a) was blocked because the browser tool returned "The browser access host is unavailable" when opening /pulse-check. No screenshot was captured and browser rendering remains unverified. Method (b) succeeded with the regression-test output below. The verification transcript contains the complete Pulse Check test result block, suite totals, lint output and dev-server checks.

The three added regression cases passed

PASS app packages/app/src/components/pulse-check/PulseCheckPage.test.tsx (11.484 s)
  ✓ retries a failed catalog load and restores the dashboard after a pending request (1073 ms)
  ✓ offers another retry after a second failure and handles an empty recovery (988 ms)
  ✓ offers retry when the catalog rejects without an Error object (329 ms)

Test Suites: 1 skipped, 10 passed, 10 of 11 total
Tests:       1 skipped, 71 passed, 72 total

The tests check that Retry and the old error disappear during a pending request, the service-only catalog filter is preserved, successful recovery restores service cards and example metrics, and a later empty response retains the existing empty-catalog message. Non-Error rejections now show a fallback error instead of being mistaken for success. Responses from an obsolete effect are ignored. Existing jsdom stylesheet and React/MUI warnings appeared during the suite; the dev server also reported the existing signals events-backend 404.

The parent epic stays open. A browser capture of failure and recovery remains a follow-up when browser access is available; public-demo baseline and landing-page taste decisions remain with Johnny.

johnnyhuy and others added 2 commits November 16, 2026 20:15
Co-authored-by: OpenAI Codex <noreply@openai.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>
@johnnyhuy
johnnyhuy merged commit 78301be into main Nov 16, 2026
5 checks passed
@johnnyhuy
johnnyhuy deleted the agent/issue-149-pulse-check-retry branch November 16, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let visitors retry failed Pulse Check catalog loads

1 participant