Repository navigation
Conversation
Rename the default output folder from fl_crate_out to flwrcrate-ro-crate and write the crate directly into it, instead of an ro-crate/ sub-folder. captured_metadata.json is deleted once the crate is written (kept if writing fails), and flwrCrate warns about files in the folder that it didn't write, since they would travel with the crate. This changes the crate's path from <output_dir>/ro-crate/ to <output_dir>/.
# Conflicts: # .github/workflows/realapps.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A run now writes the crate straight into the output folder, which is renamed from
fl_crate_outtoflwrcrate-ro-crate:output_dirisflwrcrate-ro-crate, and that folder is the crate itself, with noro-crate/sub-folder. The metrics log is written straight into it (ro-crate-py skips copying a file onto itself).captured_metadata.jsonis still written during the run, so a crash leaves a record, but it is deleted once the crate is written..DS_Storeare ignored), since they would travel with the crate if the folder is shared..gitignoreand the e2e workflow use the new folder.Breaking change: the crate moves from
<output_dir>/ro-crate/ro-crate-metadata.jsonto<output_dir>/ro-crate-metadata.json, so this should go in 0.5.0 with a note in the release notes.Tests: the lifecycle test checks the folder holds exactly those three files, and two new tests cover keeping the capture when the crate can't be written, and the warning about other files.
mainis merged in; the only conflict was the path in the e2e validation step.Closes #26