Repository navigation
Conversation
JelteF
marked this pull request as ready for review
November 12, 2026 11:09
The Release sdist run failed in `test_predicate_translation.py` because the engine now prints a folded range with exclusive bounds as comparisons (duckdb/duckdb#28448). The old expectations, like `n BETWEEN 1 AND 8` for `n > 1 AND n < 8`, were wrong because they showed an inclusive range for a filter that excludes its bounds, so the test now expects the comparisons.
JelteF
force-pushed
the
bump-submodule-between-print
branch
from
November 12, 2026 11:10
0634dd8 to
1a90ce8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the engine, which now prints a folded range with exclusive bounds as comparisons instead of an inclusive BETWEEN (duckdb/duckdb#28448). The old test expectations encoded that wrong output and broke the Release sdist run, so they now expect the comparisons.