Repository navigation
Conversation
A terminating service replica was stopped regardless of whether gateway replicas had unregistered it. They sync every 15 seconds, so unregistration could land up to 16 seconds into the replica's 30-second termination deadline, cutting requests still routed to it. The terminating pipeline now waits until no running gateway replica has the job registered before stopping it, and asks the gateway replicas to sync right away. The wait is capped at a minute (`JobModel.unregister_deadline`), since an unreachable gateway replica never unregisters anything. Aborted jobs are not waited for. Part-of: #4493 Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A terminating service replica was stopped regardless of whether gateway replicas had unregistered it. They sync every 15 seconds, so unregistration could land up to 16 seconds into the replica's 30-second termination deadline, cutting requests still routed to it.
The terminating pipeline now waits until no running gateway replica has the job registered before stopping it, and asks the gateway replicas to sync right away. The wait is capped at a minute (
JobModel.unregister_deadline), since an unreachable gateway replica never unregisters anything. Aborted jobs are not waited for.Part-of: #4493
Assisted-by: Claude Opus 5.5 noreply@anthropic.com