Repository navigation
Don't wait for aborted jobs to hand over logs - #4504
Merged
Merged
Conversation
An aborted job is not asked to stop, so it keeps running, and the runner keeps reporting `has_more` until the job ends. The log drain added in #4289 waits for `has_more` to clear, so aborting a run held the container up for the whole 30-second deadline -- longer than a graceful stop, which ends within about 10 seconds. Aborted jobs now get a single pull to collect what the runner has buffered, and the container is killed on the first terminating pass. The run's termination reason is checked too: the run pipeline does not update jobs that are already terminating, so a job of a run aborted after it was stopped keeps its graceful reason and would otherwise wait out the drain. Fixes: #4503 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An aborted job is not asked to stop, so it keeps running, and the runner keeps reporting
has_moreuntil the job ends. The log drain added in #4289 waits forhas_moreto clear, so aborting a run held the container up for the whole 30-second deadline -- longer than a graceful stop, which ends within about 10 seconds.Aborted jobs now get a single pull to collect what the runner has buffered, and the container is killed on the first terminating pass.
The run's termination reason is checked too: the run pipeline does not update jobs that are already terminating, so a job of a run aborted after it was stopped keeps its graceful reason and would otherwise wait out the drain.
Fixes: #4503