Skip to content

Don't wait for aborted jobs to hand over logs - #4504

Merged
un-def merged 1 commit into
masterfrom
issue_4503_abort_log_drain
Nov 20, 2026
Merged

un-def merged 1 commit into
masterfrom
issue_4503_abort_log_drain

Conversation

@un-def

@un-def un-def commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

An aborted job is not asked to stop, so it keeps running, and the runner keeps reporting has_more until the job ends. The log drain added in #4289 waits for has_more to clear, so aborting a run held the container up for the whole 30-second deadline -- longer than a graceful stop, which ends within about 10 seconds.

Aborted jobs now get a single pull to collect what the runner has buffered, and the container is killed on the first terminating pass.

The run's termination reason is checked too: the run pipeline does not update jobs that are already terminating, so a job of a run aborted after it was stopped keeps its graceful reason and would otherwise wait out the drain.

Fixes: #4503

An aborted job is not asked to stop, so it keeps running, and the
runner keeps reporting `has_more` until the job ends. The log drain
added in #4289 waits for `has_more` to clear, so aborting a run held
the container up for the whole 30-second deadline -- longer than a
graceful stop, which ends within about 10 seconds.

Aborted jobs now get a single pull to collect what the runner has
buffered, and the container is killed on the first terminating pass.

The run's termination reason is checked too: the run pipeline does not
update jobs that are already terminating, so a job of a run aborted
after it was stopped keeps its graceful reason and would otherwise
wait out the drain.

Fixes: #4503
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@un-def
un-def merged commit 060a3a0 into master Nov 20, 2026
26 checks passed
@un-def
un-def deleted the issue_4503_abort_log_drain branch November 20, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Run abort takes longer than stop

1 participant