Repository navigation
Allow multiple replicas in the router replica group - #4498
Merged
Merged
Conversation
Drop the validator that required `replicas: 1` for the replica group with `router`. Multiple router replicas work with both routers: * SMG: the worker sync updates every running router since #4320, and handles each router independently since #4361. * Dynamo: the frontend and the workers discover each other via a dedicated etcd group since #4402, and the workers no longer depend on the router's address since #4473. Gateway registration and the in-place update check already go by group name, not by a single router job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the validator that required
replicas: 1for the replica group withrouter. Multiple router replicas work with both routers:Gateway registration and the in-place update check already go by group name, not by a single router job.