Repository navigation
fix: keep chat position vanilla unless changed manually - #38
Draft
dsnsgithub wants to merge 3 commits into
Draft
dsnsgithub wants to merge 3 commits into
dsnsgithub wants to merge 3 commits into
Conversation
The chat HUD replaced vanilla rendering with a saved screen percentage, so the box drifted when the GUI scale or resolution changed. Custom placement is now opt-in. Background, transparency, spacing, and the other chat options still draw inside vanilla's own transform. Co-authored-by: seungd <seungd@uci.edu>
…osition-c6b4 Co-authored-by: seungd <seungd@uci.edu> # Conflicts: # common/src/main/java/io/github/dolphinclient/modules/hud/gui/hud/ChatPosition.java # versions/1.8.9/src/main/java/io/github/dolphinclient/mixin/ChatHudMixin.java # versions/1.8.9/src/main/java/io/github/dolphinclient/modules/hud/gui/hud/ChatHud.java
The license check rejects the old fork header on files added after the namespace split. Co-authored-by: seungd <seungd@uci.edu>
dsnsgithub
changed the title
dsnsgithub
marked this pull request as draft
November 2, 2026 02:18
Owner
Author
|
vanilla text rendering breaks due to this change, fix soon ™️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chat no longer leaves the vanilla anchor unless Custom Position is turned on.
Vanilla places chat with a fixed inset in GUI-scaled pixels:
GameGuishifts by(0, scaledHeight - 48), thenChatGuishifts by(2, 20)and applies the chat scale option. A saved screen percentage cannot match that inset when the GUI scale or resolution changes. With the toggle off, chat is drawn inside that vanilla matrix, so the anchor stays exact at every scale and resolution.Background, text color and alpha, shadow, line spacing, scrollbar color, chat history, the new-message slide, and keeping messages after disconnect still apply in that mode. The chat box is not draggable in the HUD editor until Custom Position is enabled. Existing saved coordinates are kept and used only after the toggle is turned on.
This branch is merged with latest
main, including theio.github.dolphinclientpackage rename.Test plan
./gradlew :1.8.9:compileJava./gradlew :common:test(includingChatPositionTest)