Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The published wheels needed libObjCryst/libboost_python (Linux, macOS, Windows) from a conda environment: the old shared wheel workflow ran auditwheel and then removed the bundled libraries and pointed RPATH at the conda prefix. The nanobind build links ObjCryst++, cctbx and newmat statically and Boost is header-only, so build the wheels with cibuildwheel: - add [tool.cibuildwheel] (cp312-cp315; manylinux x86_64, macOS native, Windows AMD64; tests run on every wheel) - use the cibuildwheel shared workflow from SYMSCAE/release-scripts until it is released in scikit-package/release-scripts@v0 - derive the version from git tags with setuptools-scm instead of the static 2026.2.0rc0 placeholder - declare packaging as a runtime dependency (used by powderpattern) - trim unused ObjCryst++ submodule parts from the sdist - guard the GCC-only -O0 flag and add MSVC settings in CMakeLists.txt - ship the licenses of the statically linked code in the wheel Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
@vincefn Please see if this looks good, I'll change the link and mark it ready once latest v0 is available. For your reference the generated wheels and test results (3.15) are here https://github.com/SYMSCAE/pyobjcryst/actions/runs/42438327523. |
Collaborator
|
LGTM - I did not have the time to test the wheels (leaving for a worshop in Beijing later today), though. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
pyobjcrystuse the shared wheel-building workflow. Resolves #125.