Skip to content

chore: update python version metadata - #59

Merged
sbillinge merged 2 commits into
diffpy:mainfrom
ycexiao:update-python-version
Nov 7, 2026
Merged

sbillinge merged 2 commits into
diffpy:mainfrom
ycexiao:update-python-version

Conversation

@ycexiao

@ycexiao ycexiao commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR address?

The conda-forge PR is failing because wrong python meta data is included
conda-forge/diffpy.apps-feedstock#2

[cli] is removed since the cli part of mcp is not actually needed.

What should the reviewer(s) do?

Please review and merge the PR.

It is also worth considering update the GitHub workflow. Our workflows parse the support python version in the classifier field while the pypi reads requires-python field . It would be good if we are consistent with pypi.

https://github.com/scikit-package/release-scripts/blob/main/.github/workflows/_get-python-versions.yml

@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (905de37) to head (b85d224).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files           8        8           
  Lines         648      648           
=======================================
  Hits          646      646           
  Misses          2        2           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ycexiao
ycexiao marked this pull request as ready for review November 7, 2026 03:56
@ycexiao

ycexiao commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge it's ready for review.

@sbillinge
sbillinge merged commit b4cb23b into diffpy:main Nov 7, 2026
7 checks passed
@ycexiao ycexiao mentioned this pull request Nov 7, 2026
19 of 20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants