Repository navigation
Conversation
AKzar1el
marked this pull request as ready for review
November 17, 2026 23:22
Contributor
Author
|
@devnoname120 This focused Playwright capability PR is ready for independent review. The main Rust/Clippy/Format check and Windows/macOS service integration jobs passed, including all eight new regression tests. One unrelated dashboard layout job failed on a detached Chromium DOM element in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser_tabs({action:"new",isolatedContext:"lane06_grants_funding"})on an extension-only upstream before dispatch, without silently falling back to a shared browser profile.Target.createBrowserContext-32000 Not allowederror into an actionable failure. Do not retry potentially ambiguous operations.Incident evidence / root cause
Codexify's local November 17 startup logs show the regular
playwrightupstream repeatedly timed out after the default 20 seconds, while the separately configuredplaywright-extensionupstream had 60 seconds and could remain available. Codexify materializes upstream MCP tools only when their server successfully initializes; consequently the regular tool vanished while an incompatible extension-backed tool could still appear. Why regular Playwright initialization exceeded its deadline remains unverified.Chromium restricts
Target.createBrowserContextto browser-level DevTools sessions. Playwright's extension attaches to existing tabs; it cannot be treated as a capability-equivalent fallback.References: https://chromium.googlesource.com/chromium/src/+/6f2fb1192aff6ccb325971ac93516aa92574be3e/content/browser/devtools/protocol/target_handler.cc and https://playwright.dev/mcp/configuration/browser-extension
Verification (commit
42e253e)check: PASS (Format, Clippy, Rust tests, Rust/TypeScript browser companion contract, and related checks).cargo fmt --checkandgit diff --check: PASS; isolated worktree clean.data:fixtures confirms that independent browser contexts can be created, and also reproduces the upstream shared-tab selection and index-reuse race.cargo test --bin codexify browser_context_testsbuild compiled but matched zero tests; it is not counted as a test pass. The corrected--libcompilation was stopped after the exact committed tests passed in CI, to avoid unnecessary memory pressure on the live service.One unrelated CI job still fails
The
Diff widget layout (Chromium and WebKit)job failed inscripts/test-statistics-extras.mjswithlocator.scrollIntoViewIfNeeded: Element is not attached to the DOMon the Chromium statistics/Extras test. The affected dashboard files are not changed by this PR; basemainpassed that job previously. This is not proven a pre-existing failure, and merge must remain blocked until it is resolved or an authorized rerun passes. A targeted rerun attempt was rejected because the fork contributor lacks admin permissions on the upstream repository.Strict limitations / follow-up
This PR is capability enforcement, not complete multi-agent tab isolation. It does not transparently migrate sessions between MCP backends, restart a missing regular upstream, or fix the shared current-tab pointer and index-based selection inside Playwright's upstream implementation. The controlled Chromium fixture still reproduces two agents selecting each other's tabs when they share one backend. Until per-agent stable target identity is integrated end-to-end, do not assume concurrent agents sharing one Playwright MCP backend have safe tab ownership.
The remaining reliability work requires trusted conversation identity propagated through the bridge, stable owned-target selection across all tab actions (not only
new), and verified completion-only cleanup. It should be reviewed as a separate integrated change rather than introducing a misleading per-call fallback here.Reviewer checklist
--extension, env and CDP cases.-32000translation does not retry or infer success after ambiguous failure.Deployment: None. Do not merge/restart the live Codexify service until independent review and required checks permit it. A bounded
startupTimeoutSecfor the regular browser can be considered separately after diagnosing its slow startup.