Repository navigation
fix(browser): scope Stop dialogs and handle response timeouts safely - #26
Conversation
|
CI update after fixing the shared baseline Clippy lint in
The patch remains in draft pending the native fixture regression and the unrelated WebKit job rerun. |
Recognize localized timeout notices on application-owned error surfaces while leaving ambiguous or accepted messages unresent. Cover alert and plain-card variants plus quoted-text and unrelated-error negatives in isolated Chromium CI. Wait for the mobile back navigation control to appear in the new-chat WebKit fixture before reopening the sidebar, preventing a hydration race.
devnoname120
left a comment
There was a problem hiding this comment.
Reviewed 3cbed09. This is the first review on this PR. Restricting Stop recovery to modal dialogs fixes the stated popover case: all 8 selected native Stop/popup/iframe regressions pass. All 5 native response-timeout tests and typecheck also pass, and all 4 hosted checks are green.
The new timeout exception is page-wide rather than scoped to the matching failure surface. I reproduced a separate visible terminal error being ignored whenever another visible timeout alert is present: the same terminal card returns failed without the old timeout and is allowed with it. The exception should only exempt the matching delivery-timeout card and leave other terminal errors blocking. The inline finding identifies the condition.
Keep open for that correction and mixed-error coverage. No production browser session was used.
devnoname120
left a comment
There was a problem hiding this comment.
Implemented the timeout-scoping finding directly on this branch. Each visible regeneration/terminal-error surface is checked independently; a timeout exempts only its own app-owned card/control and never another error elsewhere on the page. Validation: 177 offline tests and all nine native timeout cases pass, including both card orders, shared wrappers, non-ARIA cards and quoted content; typecheck/build pass. Hosted Linux check plus Windows/macOS service integration are already green; the layout job is still running. No remaining blocking finding in the reviewed changes.
Problem
Two independent ChatGPT browser states can interrupt valid Codexify goal turns:
role="dialog", even though it is not a modal Stop confirmation. Treating it as a Stop dialog can prevent the next legitimate goal turn.Focused changes
aria-modal="true"Stop dialogs (including modalalertdialog); ignore non-modal suggestion/tool popovers.Validation
git diff --check: passing.Scope and maintainer integration
This PR is limited to browser response/Stop safety, the relevant fixtures, and a UI-test synchronization fix. No payment integration, additional browser pool, permission grant, credentials, or production rollout is included. The owner can review/merge it independently of the broader browser companion work in #22 or selectively incorporate the small changes there if it is preferable.
Deployment note: source and fixture testing do not mean the user's installed Windows companion has been updated. A separate guarded local updater encountered a packaging exception and should be verified or repaired before claiming a runtime rollout.