Skip to content

Keep Observer credentials out of auth errors - #300

Merged
RogerLindquist merged 1 commit into
mainfrom
codex/codeql-token-logging
Nov 18, 2026
Merged

RogerLindquist merged 1 commit into
mainfrom
codex/codeql-token-logging

Conversation

@YoungDan

Copy link
Copy Markdown
Member

Observer HTTP 401 errors now report the HTTP status only and preserve the API-token and OIDC error codes. This keeps response bodies out of CLI error output. Test failure messages no longer print the unexpected error payload. Regression coverage checks JSON and plain-text responses with synthetic values.

Addresses CodeQL alerts #2 through #9.

@YoungDan
YoungDan requested a review from a team as a code owner November 17, 2026 14:21

@RogerLindquist RogerLindquist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Returning early on 401 with only the status keeps response bodies out of the error, and the exact-match asserts in the tests would catch a leak. Nit: the 401 message no longer includes the request path, so if that context is useful, add it back. The path is safe to show.

@RogerLindquist
RogerLindquist merged commit f3fc4c6 into main Nov 18, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants