Repository navigation
Keep Observer credentials out of auth errors - #300
Merged
Merged
Conversation
RogerLindquist
approved these changes
Nov 18, 2026
RogerLindquist
left a comment
Member
There was a problem hiding this comment.
Looks good. Returning early on 401 with only the status keeps response bodies out of the error, and the exact-match asserts in the tests would catch a leak. Nit: the 401 message no longer includes the request path, so if that context is useful, add it back. The path is safe to show.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observer HTTP 401 errors now report the HTTP status only and preserve the API-token and OIDC error codes. This keeps response bodies out of CLI error output. Test failure messages no longer print the unexpected error payload. Regression coverage checks JSON and plain-text responses with synthetic values.
Addresses CodeQL alerts #2 through #9.