Skip to content

deny: ignore RUSTSEC-2026-0543 (chrono unmaintained) - #62

Open
SrishtiCode wants to merge 1 commit into
mainfrom
chore/deny-chrono-unmaintained
Open

SrishtiCode wants to merge 1 commit into
mainfrom
chore/deny-chrono-unmaintained

Conversation

@SrishtiCode

Copy link
Copy Markdown
Collaborator

cargo deny now fails on every branch on RUSTSEC-2026-0543: chrono is unmaintained, no safe upgrade. It isn't a vulnerability and isn't a direct dependency: cedar-policy-core brings it in, via verified-derivation. This ignores it with a reason in deny.toml and fuzz/deny.toml, as for RUSTSEC-2023-0071, to revisit when cedar drops chrono. Same as dekrops/counterplay#184. Unblocks #61.

@claude

claude Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Claude finished @SrishtiCode's task in 1m 10s —— View job


Claude review: no actionable issues found

PR summary. Adds an ignore entry for RUSTSEC-2026-0543 (chrono unmaintained) to both deny.toml and fuzz/deny.toml, with a reason mirroring the format of the existing RUSTSEC-2023-0071 entry. Unblocks the daily deny run on every branch until Cedar drops chrono.

Key changes reviewed

  • deny.toml:18-21 — new advisories ignore for RUSTSEC-2026-0543 with reason.
  • fuzz/deny.toml:20-23 — matching ignore in the fuzz workspace so the two configs stay in sync (same pattern already used for RUSTSEC-2023-0071).
  • No other files touched; no crate added, removed, pinned or unpinned; no license policy change.

Verification

  • Cargo.lock lists chrono 0.4.45 only as a transitive dep: cedar-policy-core 4.10.0 → chrono (and cedar-policy-core → serde_with → chrono). No workspace Cargo.toml depends on chrono directly (grep chrono **/Cargo.toml empty), so the stated provenance ("only via cedar-policy-core, no alternative yet") is accurate.
  • Advisory ID format and object-form { id, reason } match cargo-deny advisories v2 and the existing RUSTSEC-2023-0071 entry.
  • Scope is narrow: an unmaintained advisory, not vulnerability. No cryptography, no WVP evaluators, no canonical/signing path, no runtime behavior, no CI workflow changes.

Areas reviewed

  • deny.toml, fuzz/deny.toml diff and surrounding config.
  • Cargo.lock to confirm chrono's source and consumers.
  • Workspace Cargo.toml files to confirm no direct chrono dependency.

Areas skipped

  • Decision records, crate code, docs — unchanged and out of scope for a dependency-policy ignore.

Findings

  • Critical: 0 · High: 0 · Medium: 0 · Low: 0. No inline comments posted.

Residual risks

  • The ignore is open-ended (no expiry date). If Cedar does not drop chrono, this entry will outlive its usefulness silently. Optional, non-blocking: add expiration = "YYYY-MM-DD" (cargo-deny supports it on ignore entries) or pair with a tracked issue so the "revisit when cedar drops it" prompt doesn't rely solely on reviewer memory. The existing RUSTSEC-2023-0071 entry has the same shape, so leaving this one as-is is also consistent with repo precedent.

I'm unable to approve this PR directly from the review bot (security policy). You can find more information in the FAQ.

  • Read repo guidance and configs
  • Inspect the PR diff on origin/main...HEAD
  • Verify the ignore target and reasoning for RUSTSEC-2026-0543
  • Post summary (no inline findings)
    · branch: chore/deny-chrono-unmaintained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant