[arzafran]

What this does

Two nightly UI test classes have failed every night since 10-31. The app works; both tests were written for behavior that has since changed on purpose. This updates the tests so the nightly goes back to reporting real failures.

Summary

• BonsplitTabDragUITests.testMinimalModeCollapsedSidebarKeepsPaneTabBarControlsVisible: it looked for the workspace-level "New Terminal Tab" button, which feat: give each pane card a header with quiet split, zoom and close controls (INC-376) #505 (INC-376) replaced with per-pane header controls. The failure output shows Split Right, Split Down, Zoom Pane and Close Tab in the header. The test now checks the always-visible Split Right control with the same two assertions (visible at launch, still visible after hovering away).
• TerminalCmdClickUITests, the four alt-screen cases: the fixture prints its lines on the alternate screen and then returns to the prompt. Since fix: reset mouse and screen modes at the prompt after a program is killed #511, the shell integration leaves the alternate screen at every prompt, so the lines were gone before the test read them (renderedTokenCount 1, which is the typed command line). The fixture now ends with sleep 600 so it holds the alternate screen the way a TUI does. Follow-up hover and click commands run inside the app, not through the shell, so the sleep blocks nothing.

The last nightly where both passed was 10-29 on efe837b8d5. The 10-30 run failed one alt-screen cmd-click once with a different error (setup succeeded, the click did not open); the setup failure in all four started on 10-31, the first nightly with #511.

Linear: INC-441

Test Plan

• On a tagged build, ran the exact old fixture command and read the terminal text: 1 match. With ; sleep 600: 21 matches (the test needs 6).
• ./scripts/reload.sh --tag board-clear builds.
• Targeted nightly run 41364171576 (ui_classes="BonsplitTabDragUITests TerminalCmdClickUITests"): expect both classes to pass.
• PR CI green.