Skip to content

Feat/hww - #1368

Draft
sneurlax wants to merge 22 commits into
stagingfrom
feat/hww
Draft

Feat/hww#1368
sneurlax wants to merge 22 commits into
stagingfrom
feat/hww

Conversation

@sneurlax

@sneurlax sneurlax commented May 27, 2026

Copy link
Copy Markdown
Member

No description provided.

sneurlax added 22 commits April 28, 2026 22:47
@sneurlax
chore(hww): add hardware wallet deps
419bc5d
@sneurlax
feat(hww): add supportsHardwareWallet currency getter
3d4e99a
@sneurlax
feat(hww): add core abstractions
76aeb84
@sneurlax
feat(hww): add PSBT builder
5a87cf1
@sneurlax
feat(hww): add Ledger USB adapter and Bitcoin service
aa88c10
@sneurlax
feat(hww): add Trezor adapter stub
7f34637
@sneurlax
feat(hww): add mock hardware wallet service
719c94e
@sneurlax
feat(hww): add Monero external signer service
db03992
@sneurlax
feat(hww): add WalletInfo keys
97fb0eb
@sneurlax
feat(hww): support xpubs in BIP39 HD derivation
f148b83
@sneurlax
feat(hww): skip mnemonic and key storage
435eb00
@sneurlax
feat(hww): build PSBTs for ElectrumX sends
7e3bb7e
@sneurlax
feat(hww): add mock auto-signer pref and dev toggle
7e19e02
@sneurlax
feat(hww): add Riverpod providers and scan controller
0c6295e
@sneurlax
feat(hww): add Hardware option to create wallet flow
45487c8
@sneurlax
feat(hww): add connect view, reconnect dialog, and route
a888270
@sneurlax
feat(hww): add confirm dialog and PSBT signing flow
ce576f0
@sneurlax
feat(hww): add desktop device status button and delete flow
efdb917
@sneurlax
test(hww): add integration tests
f19e7b5
@sneurlax
feat(hww): add mock devices
9f3f750
@sneurlax
chore(hww): gate hardware-wallet support to supported coins and isola…
3456b95 
…te mock signer

Default supportsHardwareWallet to false on the base CryptoCurrency and
override to true only for mainnet Bitcoin, whose Ledger BIP84 m/84'/0'/0'
derivation is implemented. This stops the create flow from offering hardware
wallets for coins that would derive a mismatched xpub.

Gate the mock auto-signer toggle and its fake balance/UTXO injection behind
kDebugMode so release builds can never enable fake balances. The mock harness
itself is left intact for tests.

Note a TODO for hardware account discovery; the connect path is still hardcoded.
@sneurlax
Merge commit 'd29d84c660492fd6dcc7ee67dbce4a76e85c026a' into refresh-…
c58693a 
…20261110/pr-1368

# Conflicts:
#	lib/pages/send_view/confirm_transaction_view.dart
#	lib/wallets/crypto_currency/coins/monero.dart
#	lib/wallets/crypto_currency/crypto_currency.dart
#	lib/wallets/wallet/wallet.dart
#	pubspec.lock
@sneurlax

sneurlax commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

Merged staging at d29d84c660492fd6dcc7ee67dbce4a76e85c026a and reviewed the hardware wallet flow. Ledger signing now uses the pinned library's PSBTv2/raw-transaction contract; it authenticates each funding transaction, preserves the selected RBF sequence, and verifies the returned transaction against the reviewed inputs and outputs before broadcast. Missing or unsupported signing data no longer falls back to the mock signer, and persisted mock settings are ignored outside debug builds. The signing dialog handles completion after it has closed, and the connect screen handles a constrained desktop window.

Validation: 76 focused hardware, signing, PSBT, provider and widget tests passed; targeted Dart analysis reported no errors or warnings, with informational lints. Real Ledger hardware, firmware compatibility, USB behavior, and an actual broadcast have not been tested. The implemented flow is limited to desktop Ledger Bitcoin mainnet BIP84 account 0; Trezor/Foundation and other networks/coins are not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sneurlax