Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1363 +/- ##
===========================================
+ Coverage 13.92% 14.22% +0.30%
===========================================
Files 1139 1140 +1
Lines 114707 114797 +90
===========================================
+ Hits 15976 16335 +359
+ Misses 98731 98462 -269 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
sneurlax
marked this pull request as draft
August 20, 2026 18:58
1 task
Adds Monero(CryptoCurrencyNetwork.stage) as sXMR, threads an explicit nettype through the cs_monero interface so create/load/restore cannot silently fall back to mainnet, and counts stage as a test network. Stagenet addresses are validated in Dart. monero_c's addressValid() takes an int nettype, which binds to wallet2's deprecated addressValid(str, bool testnet) overload, so no argument passed through FFI can select stagenet: any non zero value validates as testnet. Also gives Xelis(stage) its stagenet node; that switch arm duplicated the testnet one and was unreachable, so defaultNode() threw.
sneurlax
force-pushed
the
feat/stagenet
branch
from
August 24, 2026 21:31
acee477 to
a2c7bd9
Compare
Member
Author
Adds Monero(CryptoCurrencyNetwork.stage) as sXMR, threads an explicit nettype through the cs_monero interface so create/load/restore cannot silently fall back to mainnet, and counts stage as a test network. Stagenet addresses are validated in Dart. monero_c's addressValid() takes an int nettype, which binds to wallet2's deprecated addressValid(str, bool testnet) overload, so no argument passed through FFI can select stagenet: any non zero value validates as testnet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh review (2026-11-10)
Refresh review bounds untrusted Monero address-tag input before decoding and preserves the latest restore flow requiring a block height.
Checks: Monero stagenet address and restore tests (7 passed). Analysis reported three unused-field warnings in the Monero wallet intermediate path; no errors.