Skip to content

test: cover the event accessors no test reached -- the scroll, button… - #20

Merged
ctrondlp merged 3 commits into
mainfrom
P2-untested-accessor-coverage
Oct 31, 2026
Merged

ctrondlp merged 3 commits into
mainfrom
P2-untested-accessor-coverage

Conversation

@ctrondlp

Copy link
Copy Markdown
Owner

…, absolute-motion and emulating-sequence reads on eis.Event, ei.Event.keyboard_xkb_modifiers and eis.Device.device_type/height are each a ctypes binding to a separate C symbol, where a wrong name or restype hides from reading and only shows when the library is asked, so drive them all through one socketpair negotiation and assert every value round-trips exactly

…, absolute-motion and emulating-sequence reads on eis.Event, ei.Event.keyboard_xkb_modifiers and eis.Device.device_type/height are each a ctypes binding to a separate C symbol, where a wrong name or restype hides from reading and only shows when the library is asked, so drive them all through one socketpair negotiation and assert every value round-trips exactly
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

ctrondlp and others added 2 commits October 31, 2026 07:04
…is the only release that stores it

eis_queue_device_start_emulating_event() built the event and never copied
the sequence into it, so eis_event_emulating_get_sequence() returned a
zeroed struct field for every client -- upstream added the one missing
assignment in libei 98cd152, released in 1.6.0 and in no earlier tag
(measured 0 on 1.2.1, 1.3.901 and 1.5.0, 4242 on 1.6.0). requires_symbol
is blind to this class of difference, where every version from the 1.0.0
floor up exports the symbol and only the answer changed, so conftest grew
has_symbol() for a branch instead of a skip; the 0 is asserted rather than
skipped, keeping the newly documented behaviour under test on an old
library. Documented on the property and in the README beside
touch_up_event, the other accessor that degrades rather than raising.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ctrondlp
ctrondlp merged commit 731a1eb into main Oct 31, 2026
9 checks passed
@ctrondlp
ctrondlp deleted the P2-untested-accessor-coverage branch October 31, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant