Skip to content

Show order date in activity orders list - #1287

Draft
jay23606 wants to merge 1 commit into
csvalpha:stagingfrom
jay23606:pr-go-simple/1180
Draft

jay23606 wants to merge 1 commit into
csvalpha:stagingfrom
jay23606:pr-go-simple/1180

Conversation

@jay23606

Copy link
Copy Markdown

Fixes #1180.

The Bestellingen (orders) tab on the activity page showed only the time of each order (format: :time_only). It now uses the existing :with_year format (dd-mm-yy HH:MM), the same format used by the credit mutation and payment lists, so it's easy to spot when an order was placed on the wrong activity.

Changes:

  • app/views/activities/show.html.erb: orders column uses format: :with_year.
  • spec/controllers/activities_controller/show_spec.rb: new regression spec (render_views, treasurer) asserting the rendered orders tab includes the order's date and time.

Tests: not run here. Ruby and Bundler are not installed in this environment and dependencies were not installed, per the task rules. CI should run the new spec and RuboCop.

Tests not run here: bundle exec rspec spec/controllers/activities_controller/show_spec.rb (Ruby/Bundler not available in this environment; dependencies not installed per task rules), bundle exec rubocop (not available in this environment)

Fixes #1180

🤖 Generated with Claude Code

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add date colom to order list

1 participant